Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce Python code style #5

Closed
xushiyan opened this issue May 4, 2024 · 4 comments · Fixed by #101
Closed

Enforce Python code style #5

xushiyan opened this issue May 4, 2024 · 4 comments · Fixed by #101
Assignees
@muyihao
Labels
dev-x Dev experience: code format, dev tooling, project management good first issue Good for newcomers python Related to Python codebase
Milestone
release-0.2.0

Comments

@xushiyan
Copy link
Member

xushiyan commented May 4, 2024 •
edited
Loading

we should configure

in pyproject.toml
@xushiyan xushiyan added this to the release-0.1.0 milestone May 4, 2024
@xushiyan xushiyan added the dev-x Dev experience: code format, dev tooling, project management label May 4, 2024
@xushiyan xushiyan changed the title Add formatter flow to enforce code style Enforce Python code style May 5, 2024
@xushiyan xushiyan self-assigned this Jul 6, 2024
@xushiyan xushiyan modified the milestones: release-0.1.0, release-0.2.0 Jul 12, 2024
@xushiyan xushiyan added the good first issue Good for newcomers label Jul 18, 2024
@xushiyan xushiyan removed their assignment Jul 18, 2024
@xushiyan xushiyan added the python Related to Python codebase label Jul 18, 2024
@xushiyan xushiyan mentioned this issue Jul 21, 2024
Open
@muyihao
Copy link
Contributor

muyihao commented Jul 23, 2024

Hi, I'd like to work on this issue.

@abyssnlp
Copy link
Contributor

I can take this and #73 if required. Let me know.

@xushiyan
Copy link
Member Author

@muyihao are you planning to start on this ?

@muyihao
Copy link
Contributor

muyihao commented Jul 26, 2024

@xushiyan Yes, I am currently working on this issue. I will provide updates as I make progress. Thanks!

@muyihao muyihao mentioned this issue Jul 27, 2024
Closed
4 tasks
@xushiyan xushiyan linked a pull request Jul 27, 2024 that will close this issue
feat: add pre-commit hooks and format existing code #100
Closed
4 tasks
@muyihao muyihao mentioned this issue Jul 28, 2024
Merged
4 tasks
muyihao pushed a commit to muyihao/hudi-rs that referenced this issue Jul 28, 2024
style: enforce python code style (apache#5)
1daae3f 
- Add Ruff and MyPy configurations to pyproject.toml
- Integrate Python linting in GitHub Actions
- Format code with Ruff and Ruff Format
xushiyan pushed a commit to muyihao/hudi-rs that referenced this issue Jul 30, 2024
@xushiyan
style: enforce python code style (apache#5)
b545ce2 
- Add Ruff and MyPy configurations to pyproject.toml
- Integrate Python linting in GitHub Actions
- Format code with Ruff and Ruff Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muyihao muyihao

Labels
dev-x Dev experience: code format, dev tooling, project management good first issue Good for newcomers python Related to Python codebase
Projects
None yet
Milestone
release-0.2.0
3 participants
@xushiyan @muyihao @abyssnlp