improved dummy tests

gobblin-temporal/src/main/java/org/apache/gobblin/temporal/yarn/YarnService.java

@@ -70,7 +70,6 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import com.google.common.annotations.VisibleForTesting;
 import com.google.common.base.Optional;
 import com.google.common.base.Preconditions;
 import com.google.common.base.Strings;
@@ -134,7 +133,6 @@ class YarnService extends AbstractIdleService {
   private final Optional<GobblinMetrics> gobblinMetrics;
   private final Optional<EventSubmitter> eventSubmitter;
 
-  @VisibleForTesting
   @Getter(AccessLevel.PROTECTED)
   private final AMRMClientAsync<AMRMClient.ContainerRequest> amrmClientAsync;
   private final NMClientAsync nmClientAsync;
@@ -490,8 +488,7 @@ protected ByteBuffer getSecurityTokens() throws IOException {
     }
   }
 
-  @VisibleForTesting
-  protected String buildContainerCommand(Container container, String workerProfileName, WorkerProfile workerProfile) {
+  private String buildContainerCommand(Container container, String workerProfileName, WorkerProfile workerProfile) {
     Config workerProfileConfig = workerProfile.getConfig();
 
     double workerJvmMemoryXmxRatio = ConfigUtils.getDouble(workerProfileConfig,

gobblin-temporal/src/test/java/org/apache/gobblin/temporal/dynamic/DummyScalingDirectiveSource.java

@@ -70,6 +70,18 @@ public List<ScalingDirective> getScalingDirectives() {
           new ScalingDirective("firstProfile", 5, currentTime),
           new ScalingDirective("secondProfile", 3, currentTime + 1)
       );
+    } else if (currNumInvocations == 3) {
+      // changing set point to 0 for both profiles so that all containers should be released
+      return Arrays.asList(
+          new ScalingDirective("firstProfile", 0, currentTime),
+          new ScalingDirective("secondProfile", 0, currentTime + 1)
+      );
+    } else if (currNumInvocations == 4) {
+      // increasing containers count for both profiles so that new containers should be launched
+      return Arrays.asList(
+          new ScalingDirective("firstProfile", 5, currentTime),
+          new ScalingDirective("secondProfile", 5, currentTime + 1)
+      );
     }
     return new ArrayList<>();
   }

gobblin-temporal/src/test/java/org/apache/gobblin/temporal/yarn/DynamicScalingYarnServiceManagerTest.java

@@ -69,14 +69,14 @@ public void testWhenScalingDirectivesIsNulOrEmpty() throws IOException, Interrup
   /** Note : this test uses {@link DummyScalingDirectiveSource}*/
   @Test
   public void testWithDummyScalingDirectiveSource() throws IOException, InterruptedException {
-    // DummyScalingDirectiveSource returns 2 scaling directives in first 3 invocations and after that it returns empty list
-    // so the total number of invocations after three invocations should always be 3
+    // DummyScalingDirectiveSource returns 2 scaling directives in first 5 invocations and after that it returns empty list
+    // so the total number of invocations after three invocations should always be 5
     TestDynamicScalingYarnServiceManager testDynamicScalingYarnServiceManager = new TestDynamicScalingYarnServiceManager(
         mockGobblinTemporalApplicationMaster, new DummyScalingDirectiveSource());
     testDynamicScalingYarnServiceManager.startUp();
-    Thread.sleep(5000); // 5 seconds sleep so that GetScalingDirectivesRunnable.run() is called for 5 times
+    Thread.sleep(7000); // 5 seconds sleep so that GetScalingDirectivesRunnable.run() is called for 7 times
     testDynamicScalingYarnServiceManager.shutDown();
-    Mockito.verify(mockDynamicScalingYarnService, Mockito.times(3)).reviseWorkforcePlanAndRequestNewContainers(Mockito.anyList());
+    Mockito.verify(mockDynamicScalingYarnService, Mockito.times(5)).reviseWorkforcePlanAndRequestNewContainers(Mockito.anyList());
   }
 
   @Test