Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for wasm32 + parquet build #15158

Open
alamb opened this issue Mar 11, 2025 · 1 comment
Open

Add test coverage for wasm32 + parquet build #15158

alamb opened this issue Mar 11, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Mar 11, 2025

Is your feature request related to a problem or challenge?

We do have a very nice wasmtest test to make sure datafusion is buildable with wasmpack (thanks @jonmmease !):

linux-wasm-pack:
name: build with wasm-pack
runs-on: ubuntu-latest
container:
image: amd64/rust
steps:
- uses: actions/checkout@v4
- name: Setup Rust toolchain
uses: ./.github/actions/setup-builder
with:
rust-version: stable
- name: Install wasm-pack
run: curl https://rustwasm.github.io/wasm-pack/installer/init.sh -sSf | sh
- name: Build with wasm-pack
working-directory: ./datafusion/wasmtest
run: wasm-pack build --dev

However, As discussed here, that test doesn't use parquet and thus we broke parquet compilation

@XiangpengHao added the feature flag to the build in #1510 but wasmtest doesn't actually do anythign with parquet. So the flag could be removed accidentally in the future and all tests would still pass

Describe the solution you'd like

I would like to extend the wasmtest binary to actually something with parquet via wasm (not just adding the feature flag as in this PR)

Perhaps it could just open a parquet file, or try writing one into memory

Describe alternatives you've considered

No response

Additional context

No response

@alamb alamb added the enhancement New feature or request label Mar 11, 2025
@pranavJibhakate
Copy link

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants