Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Wildcard from Expr #14635

Closed
findepi opened this issue Feb 12, 2025 · 1 comment
Closed

Remove Wildcard from Expr #14635

findepi opened this issue Feb 12, 2025 · 1 comment

Comments

@findepi
Copy link
Member

findepi commented Feb 12, 2025

Wildcard is not an expression. It should not be part of Expr enum

it doesn't even have a type

Expr::Wildcard { .. } => Ok(DataType::Null),
Expr::GroupingSet(_) => {
// Grouping sets do not really have a type and do not appear in projections
Ok(DataType::Null)
}

I also think it's necessary to move the ExpandWildcardRule to the builder.

That would be great!

That could potentially unlock removing Expr::Wildcard. It's not really an expression (just like Expr::Alias isn't #1468 and Sort weren't #12193)

Originally posted by @findepi in #14380

@findepi
Copy link
Member Author

findepi commented Feb 12, 2025

i changed the title of #7765 to better reflect it already covers removal, not only deprecation

@findepi findepi closed this as completed Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant