Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building time for cargo bench takes quite a long time #11569

Open
jayzhan211 opened this issue Jul 20, 2024 · 3 comments
Open

Building time for cargo bench takes quite a long time #11569

jayzhan211 opened this issue Jul 20, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@jayzhan211
Copy link
Contributor

jayzhan211 commented Jul 20, 2024

Is your feature request related to a problem or challenge?

Running cargo bench --bench math_query_sql takes almost 4min for building, @goldmedal reported that it takes about 10min for him

Most of the time stuck at datafusion/core crate.

Describe the solution you'd like

Find the root cause and reduce the building time if possible

Describe alternatives you've considered

No response

Additional context

No response

@jayzhan211 jayzhan211 added the enhancement New feature or request label Jul 20, 2024
@goldmedal
Copy link
Contributor

By the way, I only modified a small part of the codebase, but it takes about 10 minutes to compile (I have builded it once). I guess it rebuilds everything every time.

@Omega359
Copy link
Contributor

5:45 here in a docker .devcontainer to run that bench command. I suspect a good portion of it is because cargo bench uses the bench profile which inherits from release. Adding --profile=dev to the command reduces the build down to 56s here.

@jayzhan211
Copy link
Contributor Author

jayzhan211 commented Jul 30, 2024

5:45 here in a docker .devcontainer to run that bench command. I suspect a good portion of it is because cargo bench uses the bench profile which inherits from release. Adding --profile=dev to the command reduces the build down to 56s here.

release mode is prefer for benchmarking, therefore it doesn't seem like a good idea to add --profile=dev

btw, I thought dev mode usually has longer build time, why is it not 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants