Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CXF-5052] Classpath references should be understood using wsdlRoot batch processing options in cxf-codegen #384

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

oli-ver
Copy link

@oli-ver oli-ver commented Feb 23, 2018

First proposal for a classpath replacement of local file url in generated class file.

A wsdlPath set in defaultOptions beginning with classpath; replaces the file url "file:/path/to/package1/package2/myfile.wsdl" with "classpath:/package1/package2/myfile.wsdl".

Just the first idea on how to achieve this, I am very open for different ideas.

@oli-ver oli-ver force-pushed the cxf-5052_classpath_ref branch from ee2da7c to 14012e6 Compare February 24, 2018 06:46
@oli-ver oli-ver force-pushed the cxf-5052_classpath_ref branch from 14012e6 to e65c5d6 Compare February 24, 2018 06:56
@deki
Copy link
Contributor

deki commented Feb 25, 2018

Thanks for your PR. Could you please add a testcase to the src/it folder? There are already two testcases so just copy and adapt one of them...

@oli-ver
Copy link
Author

oli-ver commented Feb 25, 2018

@deki I added a testcase, but I am not sure, how it should be executed. Nevertheless: When I run mvn generate-sources in the folder src/it/wsdl-classpath-resolution the example generates classes with classpath URLs.

@deki
Copy link
Contributor

deki commented Jun 5, 2018

@oli-ver this could be part of the 3.2.5 release. are you able to finish it?

@oli-ver
Copy link
Author

oli-ver commented Jun 13, 2018

@deki Sorry for my contiously late answers. What is the due date for 3.2.5? Are you ok with the solution I suggested here, when the tests do work? I personally think it is better to have a special XML node for this, but I would have to figure out how to create new ones first and find time to implement it. Sorry, at the moment there are too many other things going on :)

@deki
Copy link
Contributor

deki commented Jun 18, 2018

The release is planned for today.

Regarding your solution: Why not using classpath: instead of classpath;?

@oli-ver
Copy link
Author

oli-ver commented Jun 19, 2018

I did not want the expression to look like a classpath, because it‘s only a replacement string. Do you think classpath: would be a better syntax?

@deki
Copy link
Contributor

deki commented Jun 19, 2018

Ah ok got it. I this case a separate tag would be cleaner to avoid confusion.

rnetuka pushed a commit to rnetuka/cxf that referenced this pull request Oct 3, 2022
[ENTESB-18592] Upgrade to Xerces SMX 2.12.2.1-fuse-redhat-00003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants