-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CXF-5052] Classpath references should be understood using wsdlRoot batch processing options in cxf-codegen #384
base: main
Are you sure you want to change the base?
Conversation
ee2da7c
to
14012e6
Compare
14012e6
to
e65c5d6
Compare
Thanks for your PR. Could you please add a testcase to the src/it folder? There are already two testcases so just copy and adapt one of them... |
…to a local file path
@deki I added a testcase, but I am not sure, how it should be executed. Nevertheless: When I run mvn generate-sources in the folder src/it/wsdl-classpath-resolution the example generates classes with classpath URLs. |
@oli-ver this could be part of the 3.2.5 release. are you able to finish it? |
@deki Sorry for my contiously late answers. What is the due date for 3.2.5? Are you ok with the solution I suggested here, when the tests do work? I personally think it is better to have a special XML node for this, but I would have to figure out how to create new ones first and find time to implement it. Sorry, at the moment there are too many other things going on :) |
The release is planned for today. Regarding your solution: Why not using classpath: instead of classpath;? |
I did not want the expression to look like a classpath, because it‘s only a replacement string. Do you think classpath: would be a better syntax? |
Ah ok got it. I this case a separate tag would be cleaner to avoid confusion. |
[ENTESB-18592] Upgrade to Xerces SMX 2.12.2.1-fuse-redhat-00003
First proposal for a classpath replacement of local file url in generated class file.
A wsdlPath set in defaultOptions beginning with classpath; replaces the file url "file:/path/to/package1/package2/myfile.wsdl" with "classpath:/package1/package2/myfile.wsdl".
Just the first idea on how to achieve this, I am very open for different ideas.