-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Add parsedData to Hl7v2Message and Update HL7v2IO Docs #34213
base: master
Are you sure you want to change the base?
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
@robertwb @Abacn @svetakvsundhar Hey gentle ping. Could you please take a look and provide me with comments to improve this pr. |
Hi @svetakvsundhar would you mind taking a look of this HealthCareIO PR, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution; 2 requests.
-
Could you please fix the spotless checks? The log is
Error: eckstyle] [ERROR] /runner/_work/beam/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java:101:68: Unclosed HTML tag found: <a [JavadocStyle]
-
Could you please add unit tests/integration tests to ensure that this is working end to end?
@svetakvsundhar I did fix the spotless checks and was working on the tests, I tried running the test file as it was and got the following error: |
Please add a meaningful description for your change here
This PR addresses #20452 by adding support for the
parsedData
field in theHl7v2Message
class, enabling users of theHL7v2IO
connector who do not rely on schematized parsing to utilize HL7v2 messages from the Google Cloud Healthcare API.Fixes #20452
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.