Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Add parsedData to Hl7v2Message and Update HL7v2IO Docs #34213

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Suvrat1629
Copy link
Contributor

Please add a meaningful description for your change here


This PR addresses #20452 by adding support for the parsedData field in the Hl7v2Message class, enabling users of the HL7v2IO connector who do not rely on schematized parsing to utilize HL7v2 messages from the Google Cloud Healthcare API.

Fixes #20452

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@Suvrat1629
Copy link
Contributor Author

assign set of reviewers

Copy link
Contributor

github-actions bot commented Mar 8, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @Abacn for label io.
R: @svetakvsundhar for label healthcare.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Suvrat1629
Copy link
Contributor Author

@robertwb @Abacn @svetakvsundhar Hey gentle ping. Could you please take a look and provide me with comments to improve this pr.
Thank you.

@Abacn
Copy link
Contributor

Abacn commented Mar 12, 2025

Hi @svetakvsundhar would you mind taking a look of this HealthCareIO PR, thanks!

Copy link
Contributor

@svetakvsundhar svetakvsundhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution; 2 requests.

  1. Could you please fix the spotless checks? The log is
    Error: eckstyle] [ERROR] /runner/_work/beam/beam/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java:101:68: Unclosed HTML tag found: <a [JavadocStyle]

  2. Could you please add unit tests/integration tests to ensure that this is working end to end?

@Suvrat1629
Copy link
Contributor Author

@svetakvsundhar I did fix the spotless checks and was working on the tests, I tried running the test file as it was and got the following error:org.apache.beam.sdk.util.UserCodeException: java.io.IOException: Your default credentials were not found. To set up Application Default Credentials for your environment. Is it necessary for me to make an account on google cloud or is there a way to test without creating a account?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parsedData to Hl7v2Message to allows users not using schematized parsing to utilized HL7v2IO
3 participants