Build fedora 41 packages

[volga629-1]

Hello Everyone,
I am trying to build packages for fedora 41, but test suite is failing , required packages is installed. Is there are other dependency is missing ?

Version

Name:           ansible-collection-community-postgresql
Version:        3.12.0

......FFF.F..............................                                [100%]
=================================== FAILURES ===================================
______________________ TestConnectToDb.test_connect_to_db ______________________
[gw3] linux -- Python 3.13.2 /usr/bin/python3

self = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.TestConnectToDb object at 0x7fd65354dd10>
m_ansible_module = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.m_ansible_module.<locals>.DummyAnsibleModule object at 0x7fd65353e510>
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7fd653ee6fd0>
m_psycopg2 = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.m_psycopg2.<locals>.DummyPsycopg2 object at 0x7fd65353e660>

    def test_connect_to_db(self, m_ansible_module, monkeypatch, m_psycopg2):
        """Test connect_to_db(), common test."""
        monkeypatch.setattr(pg, 'psycopg', m_psycopg2)
        monkeypatch.setattr(pg, 'psycopg2', m_psycopg2)

        conn_params = pg.get_conn_params(m_ansible_module, m_ansible_module.params)
        db_connection, dummy = pg.connect_to_db(m_ansible_module, conn_params)
>       cursor = db_connection.cursor()
E       AttributeError: 'NoneType' object has no attribute 'cursor'

tests/unit/plugins/module_utils/test_postgres.py:256: AttributeError
___________ TestEnsureReqLibs.test_ensure_req_libs_has_not_psycopg2 ____________
[gw1] linux -- Python 3.13.2 /usr/bin/python3

self = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.TestEnsureReqLibs object at 0x7f5326e34190>
m_ansible_module = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.TestEnsureReqLibs.m_ansible_module.<locals>.Dummym_ansible_module object at 0x7f5326992510>

    def test_ensure_req_libs_has_not_psycopg2(self, m_ansible_module):
        """Test ensure_required_libs() with psycopg2 is None."""
        # HAS_PSYCOPG is False by default
        pg.ensure_required_libs(m_ansible_module)
>       assert 'Failed to import the required Python library (psycopg2)' in m_ansible_module.err_msg
E       AssertionError: assert 'Failed to import the required Python library (psycopg2)' in ''
E        +  where '' = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.TestEnsureReqLibs.m_ansible_module.<locals>.Dummym_ansible_module object at 0x7f5326992510>.err_msg

tests/unit/plugins/module_utils/test_postgres.py:174: AssertionError
_____________________ TestConnectToDb.test_autocommit_true _____________________
[gw0] linux -- Python 3.13.2 /usr/bin/python3

Packages

[volga629@canldev01-fedora41 SPECS]$ rpm -qa | grep  psycopg2
python3-psycopg2-2.9.9-7.fc41.x86_64
python3-psycopg2-tests-2.9.9-7.fc41.x86_64

[Andersson007]

@volga629-1 hello, could you elaborate a bit more on what you're trying to achieve?
It looks like you run the unit tests here, doesn't it?
If you use the ansible-test sanity command, you could add the --docker option (install podman or docker). In this case, it'll start in a container and i works in our CI that way w/o errors.

[volga629-1]

Thank you reply, unit test ran during rpmbuild command to create RPM packages for regular linux node installation.
Is this considered the issue or should I disable unit test during the build ?

https://docs.fedoraproject.org/en-US/packaging-guidelines/Ansible_collections/

Unit test should be disabled for fedora

%if %{defined fedora}
%bcond_without tests
%else
%bcond_with tests
%endif

%if %{with tests}
%check
%ansible_test_unit
%endif

[Andersson007]

Is this considered the issue or should I disable unit test during the build ?

we use them to test the code here, they run automatically in every PR. I don't think they are helpful outside this repo. Moreover, they use some mock objects (including for psycopg), so it says nothing about actual psycopg in the system

[volga629-1]

That correct, and I tried disable from spec file and I see galaxy.yml is contains build_ignore section, but tests are running anyway.

Is there are other method to disable it ?

Here are logs

Starting galaxy collection install process
[WARNING]: The specified collections path '/home/volga629/rpmbuild/BUILD/ansible-collection-community-postgresql-3.12.0-build/BUILDROOT/usr/share/ansible/collections/ansible_collections' is not part of the
configured Ansible collections paths '/home/volga629/.ansible/collections:/usr/share/ansible/collections'. The installed collection will not be picked up in an Ansible run, unless within a playbook-adjacent
collections directory.
Process install dependency map
Starting collection install process
Installing 'community.postgresql:3.12.0' to '/home/volga629/rpmbuild/BUILD/ansible-collection-community-postgresql-3.12.0-build/BUILDROOT/usr/share/ansible/collections/ansible_collections/community/postgresql'
community.postgresql:3.12.0 was installed successfully

Writing filelist to /home/volga629/rpmbuild/BUILD/ansible-collection-community-postgresql-3.12.0-build/community.postgresql-3.12.0/.ansible-packaging/ansible_collection_files
+ '[' '%{buildarch}' = noarch ']'
+ QA_CHECK_RPATHS=1
+ case "${QA_CHECK_RPATHS:-}" in
+ /usr/lib/rpm/check-rpaths
+ /usr/lib/rpm/check-buildroot
+ /usr/lib/rpm/redhat/brp-ldconfig
+ /usr/lib/rpm/brp-compress
+ /usr/lib/rpm/brp-strip /usr/bin/strip
+ /usr/lib/rpm/brp-strip-comment-note /usr/bin/strip /usr/bin/objdump
+ /usr/lib/rpm/redhat/brp-strip-lto /usr/bin/strip
+ /usr/lib/rpm/brp-strip-static-archive /usr/bin/strip
+ /usr/lib/rpm/check-rpaths
+ /usr/lib/rpm/redhat/brp-mangle-shebangs
+ /usr/lib/rpm/brp-remove-la-files
+ env /usr/lib/rpm/redhat/brp-python-bytecompile '' 1 0 -j4
+ /usr/lib/rpm/redhat/brp-python-hardlink
+ /usr/bin/add-determinism --brp -j4 /home/volga629/rpmbuild/BUILD/ansible-collection-community-postgresql-3.12.0-build/BUILDROOT
Scanned 17 directories and 44 files,
               processed 0 inodes,
               0 modified (0 replaced + 0 rewritten),
               0 unsupported format, 0 errors
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.rTOWpX
+ umask 022
+ cd /home/volga629/rpmbuild/BUILD/ansible-collection-community-postgresql-3.12.0-build
+ CFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer '
+ export CFLAGS
+ CXXFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer '
+ export CXXFLAGS
+ FFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -I/usr/lib/gfortran/modules '
+ export FFLAGS
+ FCFLAGS='-O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -I/usr/lib/gfortran/modules '
+ export FCFLAGS
+ VALAFLAGS=-g
+ export VALAFLAGS
+ RUSTFLAGS='-Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1 -Cstrip=none -Cforce-frame-pointers=yes --cap-lints=warn'
+ export RUSTFLAGS
+ LDFLAGS='-Wl,-z,relro -Wl,--as-needed   -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1  '
+ export LDFLAGS
+ LT_SYS_LIBRARY_PATH=/usr/lib:
+ export LT_SYS_LIBRARY_PATH
+ CC=gcc
+ export CC
+ CXX=g++
+ export CXX
+ cd community.postgresql-3.12.0
+ /usr/lib/rpm/ansible_collection.py test --python-interpreter /usr/bin/python3 --local
Loading collection metadata from /home/volga629/rpmbuild/BUILD/ansible-collection-community-postgresql-3.12.0-build/community.postgresql-3.12.0/galaxy.yml
Running: ('ansible-test', 'units', '--python-interpreter', '/usr/bin/python3', '--local')

Unit test modules with Python 3.13
============================= test session starts ==============================
platform linux -- Python 3.13.2, pytest-8.3.4, pluggy-1.5.0
rootdir: /tmp/tmpvobo0sj8/ansible_collections/community/postgresql
configfile: ../../../../../usr/lib/python3.13/site-packages/ansible_test/_data/pytest/config/default.ini
plugins: mock-3.14.0, xdist-3.6.1
created: 4/4 workers
4 workers [34 items]

..................................                                       [100%]
- generated xml file: /tmp/tmpvobo0sj8/ansible_collections/community/postgresql/tests/output/junit/python3.13-modules-units.xml -
============================== 34 passed in 1.07s ==============================
Unit test module_utils with Python 3.13
============================= test session starts ==============================
platform linux -- Python 3.13.2, pytest-8.3.4, pluggy-1.5.0
rootdir: /tmp/tmpvobo0sj8/ansible_collections/community/postgresql
configfile: ../../../../../usr/lib/python3.13/site-packages/ansible_test/_data/pytest/config/default.ini
plugins: mock-3.14.0, xdist-3.6.1
created: 4/4 workers
4 workers [41 items]

.........F.F..F.........F................                                [100%]
=================================== FAILURES ===================================
______________________ TestConnectToDb.test_connect_to_db ______________________
[gw3] linux -- Python 3.13.2 /usr/bin/python3

self = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.TestConnectToDb object at 0x7f90c8e15d10>
m_ansible_module = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.m_ansible_module.<locals>.DummyAnsibleModule object at 0x7f90c8d72510>
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f90c966efd0>
m_psycopg2 = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.m_psycopg2.<locals>.DummyPsycopg2 object at 0x7f90c8d72660>

    def test_connect_to_db(self, m_ansible_module, monkeypatch, m_psycopg2):
        """Test connect_to_db(), common test."""
        monkeypatch.setattr(pg, 'psycopg', m_psycopg2)
        monkeypatch.setattr(pg, 'psycopg2', m_psycopg2)

        conn_params = pg.get_conn_params(m_ansible_module, m_ansible_module.params)
        db_connection, dummy = pg.connect_to_db(m_ansible_module, conn_params)
>       cursor = db_connection.cursor()
E       AttributeError: 'NoneType' object has no attribute 'cursor'

tests/unit/plugins/module_utils/test_postgres.py:256: AttributeError
___________ TestEnsureReqLibs.test_ensure_req_libs_has_not_psycopg2 ____________
[gw1] linux -- Python 3.13.2 /usr/bin/python3

self = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.TestEnsureReqLibs object at 0x7f0792cc4190>
m_ansible_module = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.TestEnsureReqLibs.m_ansible_module.<locals>.Dummym_ansible_module object at 0x7f0792a1a510>

    def test_ensure_req_libs_has_not_psycopg2(self, m_ansible_module):
        """Test ensure_required_libs() with psycopg2 is None."""
        # HAS_PSYCOPG is False by default
        pg.ensure_required_libs(m_ansible_module)
>       assert 'Failed to import the required Python library (psycopg2)' in m_ansible_module.err_msg
E       AssertionError: assert 'Failed to import the required Python library (psycopg2)' in ''
E        +  where '' = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.TestEnsureReqLibs.m_ansible_module.<locals>.Dummym_ansible_module object at 0x7f0792a1a510>.err_msg

tests/unit/plugins/module_utils/test_postgres.py:174: AssertionError
______________________ TestConnectToDb.test_session_role _______________________
[gw2] linux -- Python 3.13.2 /usr/bin/python3

self = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.TestConnectToDb object at 0x7f9e832d5e50>
m_ansible_module = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.m_ansible_module.<locals>.DummyAnsibleModule object at 0x7f9e832ca510>
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f9e833a0c30>
m_psycopg2 = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.m_psycopg2.<locals>.DummyPsycopg2 object at 0x7f9e832ca660>

    def test_session_role(self, m_ansible_module, monkeypatch, m_psycopg2):
        """Test connect_to_db(), switch on session_role."""
        monkeypatch.setattr(pg, 'psycopg', m_psycopg2)
        monkeypatch.setattr(pg, 'psycopg2', m_psycopg2)

        m_ansible_module.params['session_role'] = 'test_role'
        conn_params = pg.get_conn_params(m_ansible_module, m_ansible_module.params)
        db_connection, dummy = pg.connect_to_db(m_ansible_module, conn_params)
>       cursor = db_connection.cursor()
E       AttributeError: 'NoneType' object has no attribute 'cursor'

tests/unit/plugins/module_utils/test_postgres.py:272: AttributeError
_____________________ TestConnectToDb.test_autocommit_true _____________________
[gw1] linux -- Python 3.13.2 /usr/bin/python3

self = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.TestConnectToDb object at 0x7f0792b48ef0>
m_ansible_module = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.m_ansible_module.<locals>.DummyAnsibleModule object at 0x7f0792a1acf0>
monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7f0792af4c30>
m_psycopg2 = <ansible_collections.community.postgresql.tests.unit.plugins.module_utils.test_postgres.m_psycopg2.<locals>.DummyPsycopg2 object at 0x7f0792a1ae40>

    def test_autocommit_true(self, m_ansible_module, monkeypatch, m_psycopg2):
        """
        Test connect_to_db(), autocommit arg passed as True (the default is False).
        """

        # case 1: psycopg2.__version >= 2.4.2 (the default in m_psycopg2)
        monkeypatch.setattr(pg, 'psycopg', m_psycopg2)
        monkeypatch.setattr(pg, 'psycopg2', m_psycopg2)

        conn_params = pg.get_conn_params(m_ansible_module, m_ansible_module.params)
        db_connection, dummy = pg.connect_to_db(m_ansible_module, conn_params, autocommit=True)
>       cursor = db_connection.cursor()
E       AttributeError: 'NoneType' object has no attribute 'cursor'

tests/unit/plugins/module_utils/test_postgres.py:320: AttributeError
- generated xml file: /tmp/tmpvobo0sj8/ansible_collections/community/postgresql/tests/output/junit/python3.13-module_utils-units.xml -
=========================== short test summary info ============================
FAILED tests/unit/plugins/module_utils/test_postgres.py::TestConnectToDb::test_connect_to_db - AttributeError: 'NoneType' object has no attribute 'cursor'
FAILED tests/unit/plugins/module_utils/test_postgres.py::TestEnsureReqLibs::test_ensure_req_libs_has_not_psycopg2 - AssertionError: assert 'Failed to import the required Python library (psyco...
FAILED tests/unit/plugins/module_utils/test_postgres.py::TestConnectToDb::test_session_role - AttributeError: 'NoneType' object has no attribute 'cursor'
FAILED tests/unit/plugins/module_utils/test_postgres.py::TestConnectToDb::test_autocommit_true - AttributeError: 'NoneType' object has no attribute 'cursor'
========================= 4 failed, 37 passed in 1.18s =========================
FATAL: Command "pytest -r a -n auto --color yes -p no:cacheprovider -c /usr/lib/python3.13/site-packages/ansible_test/_data/pytest/config/default.ini --junit-xml /tmp/tmpvobo0sj8/ansible_collections/community/postgresql/tests/output/junit/python3.13-module_utils-units.xml --strict-markers --rootdir /tmp/tmpvobo0sj8/ansible_collections/community/postgresql --confcutdir /tmp/tmpvobo0sj8/ansible_collections/community/postgresql tests/unit/plugins/module_utils/test_database.py tests/unit/plugins/module_utils/test_postgres.py tests/unit/plugins/module_utils/test_saslprep.py" returned exit status 1.
Command '('ansible-test', 'units', '--python-interpreter', '/usr/bin/python3', '--local')' returned non-zero exit status 1.
error: Bad exit status from /var/tmp/rpm-tmp.rTOWpX (%check)

[Andersson007]

@volga629-1 have you tried to just remove the whole tests directory?

[volga629-1]

Thank you issue is resolved.
I disabled %check in spec file.

[Andersson007]

Cool, thanks for closing!