fixes #73 ChainLP: Deleting project does not remove rows for all associations

Author: anshooarora

chainlp/backend/chainlp/src/main/java/com/aventstack/chainlp/api/build/BuildRepository.java

@@ -13,4 +13,6 @@ public interface BuildRepository extends
 
     Optional<Build> findFirstByProjectIdOrderByIdDesc(final Integer projectId);
 
+    void deleteByProjectId(final Integer projectId);
+
 }

chainlp/backend/chainlp/src/main/java/com/aventstack/chainlp/api/build/BuildService.java

@@ -23,6 +23,7 @@
 import org.springframework.data.domain.Pageable;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Isolation;
+import org.springframework.transaction.annotation.Propagation;
 import org.springframework.transaction.annotation.Transactional;
 
 import java.util.HashMap;
@@ -46,7 +47,7 @@ public class BuildService {
     private final TestService testService;
 
     public BuildService(final BuildRepository repository,
-                        final ProjectService projectService,
+                        @Lazy final ProjectService projectService,
                         final BuildStatsService buildStatsService,
                         final TagStatsService tagStatsService,
                         final TestRepository testRepository,
@@ -221,4 +222,15 @@ public void delete(final long id) {
         log.info("Build id: {} was deleted successfully", id);
     }
 
+    @Transactional(propagation = Propagation.MANDATORY)
+    @Caching(evict = {
+            @CacheEvict(value = "builds", allEntries = true, condition = "#id > 0"),
+            @CacheEvict(value = "build", allEntries = true)
+    })
+    public void deleteForProject(final Integer id) {
+        log.debug("Deleting all builds for project with id {}", id);
+        repository.deleteByProjectId(id);
+        log.info("Builds for project with id {} were deleted", id);
+    }
+
 }

chainlp/backend/chainlp/src/main/java/com/aventstack/chainlp/api/project/ProjectService.java

@@ -1,11 +1,15 @@
 package com.aventstack.chainlp.api.project;
 
+import com.aventstack.chainlp.api.build.BuildService;
+import com.aventstack.chainlp.api.test.TestService;
+import jakarta.transaction.Transactional;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.cache.annotation.CacheEvict;
 import org.springframework.cache.annotation.CachePut;
 import org.springframework.cache.annotation.Cacheable;
 import org.springframework.cache.annotation.Caching;
+import org.springframework.context.annotation.Lazy;
 import org.springframework.data.domain.Page;
 import org.springframework.data.domain.Pageable;
 import org.springframework.stereotype.Service;
@@ -19,6 +23,13 @@ public class ProjectService {
     @Autowired
     private ProjectRepository repository;
 
+    @Autowired
+    private BuildService buildService;
+
+    @Autowired
+    @Lazy
+    private TestService testService;
+
     @Cacheable(value = "projects", unless = "#result == null || #result.size == 0")
     public Page<Project> findAll(final Pageable pageable) {
         return repository.findAll(pageable);
@@ -53,11 +64,14 @@ public Project update(final Project project) {
         return project;
     }
 
+    @Transactional
     @Caching(evict = {
             @CacheEvict(value = "projects", allEntries = true, condition = "#id > 0"),
             @CacheEvict(value = "project", key = "#id", condition="#id > 0")
     })
     public void delete(final Integer id) {
+        buildService.deleteForProject(id);
+        testService.deleteForProject(id);
         log.info("Deleting project with id {}", id);
         repository.deleteById(id);
         log.info("Project id: {} was deleted successfully", id);

chainlp/backend/chainlp/src/main/java/com/aventstack/chainlp/api/test/TestRepository.java

@@ -15,4 +15,6 @@ public interface TestRepository extends
 
     void deleteByBuildId(final long buildId);
 
+    void deleteByProjectId(final Integer projectId);
+
 }

chainlp/backend/chainlp/src/main/java/com/aventstack/chainlp/api/test/TestService.java

@@ -205,4 +205,15 @@ public void clearParentRefs(final Test test) {
         }
     }
 
+    @Transactional(propagation = Propagation.MANDATORY)
+    @Caching(evict = {
+            @CacheEvict(value = "tests", allEntries = true, condition = "#id > 0"),
+            @CacheEvict(value = "test", allEntries = true)
+    })
+    public void deleteForProject(final Integer id) {
+        log.debug("Deleting all tests for project with id {}", id);
+        repository.deleteByProjectId(id);
+        log.info("Builds for tests with id {} were deleted", id);
+    }
+
 }