Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace GlobalConfiguration.DefaultCulture with CultureInfo.CurrentCulture #600

Closed
tmilnthorp opened this issue Feb 4, 2019 · 2 comments
Closed

Replace GlobalConfiguration.DefaultCulture with CultureInfo.CurrentCulture #600

tmilnthorp opened this issue Feb 4, 2019 · 2 comments
Labels
breaking-change
Milestone
5.0

Comments

@tmilnthorp
Copy link
Collaborator

Replace GlobalConfiguration.DefaultCulture with CultureInfo.CurrentCulture. Breaking change so belongs in #563.

  • CultureInfo.CurrentCulture for number formatting
  • Use CultureInfo.CurrentCulture or CultureInfo.CurrentUICulture for abbreviations?
@angularsen angularsen added this to the 5.0 milestone Feb 8, 2019
@angularsen
Copy link
Owner

Can we perhaps introduce this by using CultureInfo.CurrentCulture as the backing value and mark the class as obsolete, then remove it in v5?

@tmilnthorp
Copy link
Collaborator Author

Good idea 👍

@angularsen angularsen mentioned this issue Feb 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@angularsen @tmilnthorp