-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decompose unit conversion functions to exact coefficients (breaking) #1499
base: release/v6
Are you sure you want to change the base?
Conversation
…tions with exact coefficients (breaking)
I still want to replace the |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
…tions with exact coefficients (breaking)
5da8e22
to
80d3692
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not through everything yet but posting the review so far.
I got through all the JSON files.
…tsNet into fix-unit-conversions
…umetricHeatCapacity and Power - HydraulicHorsepower: conversion coefficient changed from {x} * 745.69988145 to 745.69987158227022
@angularsen I've merged the modifications from I'd really like to close this as soon as possible- it's blocking my 🐲 PR.. |
I'll make an honest attempt the next few days, I know I'm running late on a bunch of PRs lately and it's on my conscience, I just struggle to find the time and energy. |
This is a port of #1393, targeting the release-v6 consisting of the changes that broke one test or another.
Most of these are related to conversions involving the US/British units but there is also some confusion regarding the Calorie - the value of
4.1868
was used (instead of4.184
) in a few places, which is a note-worthy difference.Here are all the tests that broke:
HeatFlux
: due to the change inCalorie
HeatTransferCoefficient
: due to the change inCalorie
Impulse
:PoundFootPerSecond
,SlugFootPerSecond
were represented by a single coefficient that is significantly different from what got: see Decomposed the rounded expressions in the unit definitions into operations with exact coefficients #1393 (comment)Luminosity
: see Decomposed the rounded expressions in the unit definitions into operations with exact coefficients #1393 (comment).Power
: MechanicalHorsepower changed from{x} * 745.69
to{x} * 76.0402249 * 9.80665
as given by this articlePressure
the TechnicalAtmosphere coefficient (no idea where the old one was taken from), see also Decomposed the rounded expressions in the unit definitions into operations with exact coefficients #1393 (comment)SpecificFuelConsumption
: I'm not a domain expert, but{x} * 28.33
doesn't look right forPoundMassPerPoundForceHour
(lb/(lbf·h))- here's what I got:{x} * 453.59237 / (0.0044482216152605 * 3600)
ThermalResistance
: using different conversion coefficients forBTU
andCalorie
from the one defined inEnergy
(note: I wasn't able to confirm the "correct" conversion coefficient for BTU).VolumetricHeatCapacity
: using different conversion coefficient forCalorie