Skip to content

Commit 750df85

Browse files
committed
💥🐛Change DataMember ordering to 1-indexed (#1360)
Related #1200 Fixes #1356 Apparently, protobuf-net does not support 0-indexed order values. - Change `DataMember` explicit order from 0-indexed to 1-indexed Some investigation indicates that the actual order value is not important, only the relative ordering: #1356 (comment) - WCF should tolerate this, according to its docs. #1356 (comment) - Binary formatters hopefully only care about relative ordering and thus still compatible? - Protobuf-net, it never worked and should be OK - [BinaryFormatter](https://learn.microsoft.com/en-us/dotnet/api/system.runtime.serialization.formatters.binary.binaryformatter?view=net-8.0) is obsolete and generally not recommended for years, so hopefully no users are affected - A bunch of others exist too, haven't looked into how they handle this - XML/JSON serializers should tolerate any order, can't imagine it breaking these?
1 parent e86eb17 commit 750df85

File tree

124 files changed

+248
-248
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

124 files changed

+248
-248
lines changed

Diff for: CodeGen/Generators/UnitsNetGen/QuantityGenerator.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -82,13 +82,13 @@ namespace UnitsNet
8282
/// <summary>
8383
/// The numeric value this quantity was constructed with.
8484
/// </summary>
85-
[DataMember(Name = ""Value"", Order = 0)]
85+
[DataMember(Name = ""Value"", Order = 1)]
8686
private readonly {_quantity.ValueType} _value;
8787
8888
/// <summary>
8989
/// The unit this quantity was constructed with.
9090
/// </summary>
91-
[DataMember(Name = ""Unit"", Order = 1)]
91+
[DataMember(Name = ""Unit"", Order = 2)]
9292
private readonly {_unitEnumName}? _unit;
9393
");
9494
GenerateStaticConstructor();

Diff for: UnitsNet/GeneratedCode/Quantities/AbsorbedDoseOfIonizingRadiation.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/Acceleration.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/AmountOfSubstance.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/AmplitudeRatio.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/Angle.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/ApparentEnergy.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/ApparentPower.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/Area.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/AreaDensity.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/AreaMomentOfInertia.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/BitRate.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/BrakeSpecificFuelConsumption.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/Capacitance.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/CoefficientOfThermalExpansion.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/Compressibility.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/Density.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/Duration.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/DynamicViscosity.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/ElectricAdmittance.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/ElectricCharge.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/ElectricChargeDensity.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/ElectricConductance.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/ElectricConductivity.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Diff for: UnitsNet/GeneratedCode/Quantities/ElectricCurrent.g.cs

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)