Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For version 13, pin a max version of ChromeDriver #358

Closed
cnishina opened this issue Apr 10, 2019 · 1 comment
Closed

For version 13, pin a max version of ChromeDriver #358

cnishina opened this issue Apr 10, 2019 · 1 comment
Labels
P0
Milestone
Release version 1...

Comments

@cnishina
Copy link
Contributor

This should be in place until version 74 comes out.
@cnishina cnishina added the P0 label Apr 10, 2019
cnishina added a commit to cnishina/webdriver-manager that referenced this issue Apr 24, 2019
@cnishina
feat(max_versions): set max versions based on string matching
c85be39 
- Do a version match based on string startsWith of the maxVersion
  An example:

  Matching "0.1" might find versions 0.14.0, 0.151.0, 0.1.0. It will then
  get the max version which is 0.151. If a user wanted to get 0.1, then
  they could specify version "0.1."

- Fix / update interchangable aliases:
  - selenium == standalone
  - chromedriver == chrome
  - geckodriver == gecko
  - iedriver = ie

Tagging angular#280, angular#358, angular#353. Additional work is still required to have a
config file that has this information instead of hard coding it.
@cnishina cnishina mentioned this issue Apr 24, 2019
Merged
cnishina added a commit to cnishina/webdriver-manager that referenced this issue Apr 24, 2019
@cnishina
feat(max_versions): set max versions based on string matching
7ad7b6d 
- Do a version match based on string startsWith of the maxVersion
  An example:

  Matching "0.1" might find versions 0.14.0, 0.151.0, 0.1.0. It will then
  get the max version which is 0.151. If a user wanted to get 0.1, then
  they could specify version "0.1."

- Fix / update interchangable aliases:
  - selenium == standalone
  - chromedriver == chrome
  - geckodriver == gecko
  - iedriver = ie

Tagging angular#280, angular#358, angular#353. Additional work is still required to have a
config file that has this information instead of hard coding it.
cnishina added a commit to cnishina/webdriver-manager that referenced this issue Apr 24, 2019
@cnishina
feat(max_versions): set max versions based on string matching
ee4a03d 
- Do a version match based on string startsWith of the maxVersion
  An example:

  Matching "0.1" might find versions 0.14.0, 0.151.0, 0.1.0. It will then
  get the max version which is 0.151. If a user wanted to get 0.1, then
  they could specify version "0.1."

- Fix / update interchangable aliases:
  - selenium == standalone
  - chromedriver == chrome
  - geckodriver == gecko
  - iedriver = ie

Tagging angular#280, angular#358, angular#353. Additional work is still required to have a
config file that has this information instead of hard coding it.
cnishina added a commit to cnishina/webdriver-manager that referenced this issue Apr 24, 2019
@cnishina
feat(max_versions): set max versions based on string matching
69c0450 
- Do a version match based on string startsWith of the maxVersion
  An example:

  Matching "0.1" might find versions 0.14.0, 0.151.0, 0.1.0. It will then
  get the max version which is 0.151. If a user wanted to get 0.1, then
  they could specify version "0.1."
- Added a unit test to the version_list to find max versions.

- Fix / update interchangable aliases:
  - selenium == standalone
  - chromedriver == chrome
  - geckodriver == gecko
  - iedriver = ie

Tagging angular#280, angular#358, angular#353. Additional work is still required to have a
config file that has this information instead of hard coding it.
cnishina added a commit to cnishina/webdriver-manager that referenced this issue Apr 24, 2019
@cnishina
feat(max_versions): set max versions based on string matching
16ca7f3 
- Do a version match based on string startsWith of the maxVersion
  An example:

  Matching "0.1" might find versions 0.14.0, 0.151.0, 0.1.0. It will then
  get the max version which is 0.151. If a user wanted to get 0.1, then
  they could specify version "0.1."
- Added a unit test to the version_list to find max versions.

- Fix / update interchangable aliases:
  - selenium == standalone
  - chromedriver == chrome
  - geckodriver == gecko
  - iedriver = ie

Tagging angular#280, angular#358, angular#353. Additional work is still required to have a
config file that has this information instead of hard coding it.
cnishina added a commit to cnishina/webdriver-manager that referenced this issue Apr 24, 2019
@cnishina
feat(max_versions): set max versions based on string matching
bef4e3f 
- Do a version match based on string startsWith of the maxVersion
  An example:

  Matching "0.1" might find versions 0.14.0, 0.151.0, 0.1.0. It will then
  get the max version which is 0.151. If a user wanted to get 0.1, then
  they could specify version "0.1."
- Added a unit test to the version_list to find max versions.

- Fix / update interchangable aliases:
  - selenium == standalone
  - chromedriver == chrome
  - geckodriver == gecko
  - iedriver = ie

Tagging angular#280, angular#358, angular#353. Additional work is still required to have a
config file that has this information instead of hard coding it.
@everflux everflux mentioned this issue May 5, 2019
Closed
cnishina added a commit to cnishina/webdriver-manager that referenced this issue Jun 6, 2019
@cnishina
feat(max_versions): set max versions based on string matching
5ae6b5c 
- Do a version match based on string startsWith of the maxVersion
  An example:

  Matching "0.1" might find versions 0.14.0, 0.151.0, 0.1.0. It will then
  get the max version which is 0.151. If a user wanted to get 0.1, then
  they could specify version "0.1."
- Added a unit test to the version_list to find max versions.

- Fix / update interchangable aliases:
  - selenium == standalone
  - chromedriver == chrome
  - geckodriver == gecko
  - iedriver = ie

Tagging angular#280, angular#358, angular#353. Additional work is still required to have a
config file that has this information instead of hard coding it.
cnishina added a commit that referenced this issue Jun 6, 2019
@cnishina
feat(max_versions): set max versions based on string matching (#369)
c9a52b2 
- Do a version match based on string startsWith of the maxVersion
  An example:

  Matching "0.1" might find versions 0.14.0, 0.151.0, 0.1.0. It will then
  get the max version which is 0.151. If a user wanted to get 0.1, then
  they could specify version "0.1."
- Added a unit test to the version_list to find max versions.

- Fix / update interchangable aliases:
  - selenium == standalone
  - chromedriver == chrome
  - geckodriver == gecko
  - iedriver = ie

Tagging #280, #358, #353. Additional work is still required to have a
config file that has this information instead of hard coding it.
@cnishina
Copy link
Contributor Author

cnishina commented Jun 6, 2019

This is complete with #369 but in addition #280 should be maintained by the repo.

@cnishina cnishina closed this as completed Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P0
Projects
None yet
Milestone
Release version 13.0.1-beta.1
Development

No branches or pull requests
1 participant
@cnishina