Skip to content

Commit 59c562c

Browse files
author
Angular Builds
committedOct 30, 2024·
ed8f96a refactor(@angular-devkit/build-angular): adds protractor builder which throws with a clear error message
1 parent 95edf7f commit 59c562c

File tree

6 files changed

+39
-10
lines changed

6 files changed

+39
-10
lines changed
 

Diff for: ‎builders.json

+5
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,11 @@
4242
"schema": "./src/builders/web-test-runner/schema.json",
4343
"description": "Run unit tests with Web Test Runner."
4444
},
45+
"protractor": {
46+
"implementation": "./src/builders/protractor-error",
47+
"schema": "./src/builders/protractor/schema.json",
48+
"description": "Throw an error that Protractor is end-of-life and no longer supported."
49+
},
4550
"private-protractor": {
4651
"implementation": "./src/builders/protractor",
4752
"schema": "./src/builders/protractor/schema.json",

Diff for: ‎package.json

+8-8
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
{
22
"name": "@angular-devkit/build-angular",
3-
"version": "19.1.0-next.0+sha-8646751",
3+
"version": "19.1.0-next.0+sha-ed8f96a",
44
"description": "Angular Webpack Build Facade",
55
"main": "src/index.js",
66
"typings": "src/index.d.ts",
77
"builders": "builders.json",
88
"dependencies": {
99
"@ampproject/remapping": "2.3.0",
10-
"@angular-devkit/architect": "github:angular/angular-devkit-architect-builds#8646751",
11-
"@angular-devkit/build-webpack": "github:angular/angular-devkit-build-webpack-builds#8646751",
12-
"@angular-devkit/core": "github:angular/angular-devkit-core-builds#8646751",
13-
"@angular/build": "github:angular/angular-build-builds#8646751",
10+
"@angular-devkit/architect": "github:angular/angular-devkit-architect-builds#ed8f96a",
11+
"@angular-devkit/build-webpack": "github:angular/angular-devkit-build-webpack-builds#ed8f96a",
12+
"@angular-devkit/core": "github:angular/angular-devkit-core-builds#ed8f96a",
13+
"@angular/build": "github:angular/angular-build-builds#ed8f96a",
1414
"@babel/core": "7.26.0",
1515
"@babel/generator": "7.26.0",
1616
"@babel/helper-annotate-as-pure": "7.25.9",
@@ -21,7 +21,7 @@
2121
"@babel/preset-env": "7.26.0",
2222
"@babel/runtime": "7.26.0",
2323
"@discoveryjs/json-ext": "0.6.3",
24-
"@ngtools/webpack": "github:angular/ngtools-webpack-builds#8646751",
24+
"@ngtools/webpack": "github:angular/ngtools-webpack-builds#ed8f96a",
2525
"@vitejs/plugin-basic-ssl": "1.1.0",
2626
"ansi-colors": "4.1.3",
2727
"autoprefixer": "10.4.20",
@@ -70,7 +70,7 @@
7070
"@angular/localize": "^19.0.0-next.0",
7171
"@angular/platform-server": "^19.0.0-next.0",
7272
"@angular/service-worker": "^19.0.0-next.0",
73-
"@angular/ssr": "github:angular/angular-ssr-builds#8646751",
73+
"@angular/ssr": "github:angular/angular-ssr-builds#ed8f96a",
7474
"@web/test-runner": "^0.19.0",
7575
"browser-sync": "^3.0.2",
7676
"jest": "^29.5.0",
@@ -91,7 +91,7 @@
9191
"@angular/service-worker": {
9292
"optional": true
9393
},
94-
"@angular/ssr": "github:angular/angular-ssr-builds#8646751",
94+
"@angular/ssr": "github:angular/angular-ssr-builds#ed8f96a",
9595
"@web/test-runner": {
9696
"optional": true
9797
},

Diff for: ‎src/builders/protractor-error/index.d.ts

+10
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
/**
2+
* @license
3+
* Copyright Google LLC All Rights Reserved.
4+
*
5+
* Use of this source code is governed by an MIT-style license that can be
6+
* found in the LICENSE file at https://angular.dev/license
7+
*/
8+
import { Schema as ProtractorBuilderOptions } from '../protractor/schema';
9+
declare const _default: import("../../../../architect/src/internal").Builder<ProtractorBuilderOptions & import("../../../../core/src").JsonObject>;
10+
export default _default;

Diff for: ‎src/builders/protractor-error/index.js

+14
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
"use strict";
2+
/**
3+
* @license
4+
* Copyright Google LLC All Rights Reserved.
5+
*
6+
* Use of this source code is governed by an MIT-style license that can be
7+
* found in the LICENSE file at https://angular.dev/license
8+
*/
9+
Object.defineProperty(exports, "__esModule", { value: true });
10+
const architect_1 = require("@angular-devkit/architect");
11+
exports.default = (0, architect_1.createBuilder)((_options, context) => {
12+
context.logger.error('Protractor has reached end-of-life and is no longer supported. For additional information and alternatives, please see https://blog.angular.dev/protractor-deprecation-update-august-2023-2beac7402ce0.');
13+
return { success: false };
14+
});

Diff for: ‎src/utils/normalize-cache.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
1010
exports.normalizeCacheOptions = normalizeCacheOptions;
1111
const node_path_1 = require("node:path");
1212
/** Version placeholder is replaced during the build process with actual package version */
13-
const VERSION = '19.1.0-next.0+sha-8646751';
13+
const VERSION = '19.1.0-next.0+sha-ed8f96a';
1414
function hasCacheMetadata(value) {
1515
return (!!value &&
1616
typeof value === 'object' &&

Diff for: ‎uniqueId

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Tue Oct 29 2024 17:25:05 GMT+0000 (Coordinated Universal Time)
1+
Wed Oct 30 2024 15:13:17 GMT+0000 (Coordinated Universal Time)

0 commit comments

Comments
 (0)
Please sign in to comment.