Skip to content

Commit e6849e0

Browse files
oceanjulesivanbuper
authored andcommittedNov 5, 2024
Align spelling of fullScreen to fullscreen
Currently most of the public APIs use `fullscreen` (apart from the deprecated `PlayerControlView.OnFullScreenModeChangedListener` which will have to remain as is). This code changes mostly private variable naming. PiperOrigin-RevId: 688559509 (cherry picked from commit ee4f0c4)
1 parent 8fdb233 commit e6849e0

File tree

3 files changed

+63
-63
lines changed

3 files changed

+63
-63
lines changed
 

‎demos/surface/src/main/java/androidx/media3/demo/surface/MainActivity.java

+13-13
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ public final class MainActivity extends Activity {
6262

6363
private boolean isOwner;
6464
@Nullable private LegacyPlayerControlView playerControlView;
65-
@Nullable private SurfaceView fullScreenView;
66-
@Nullable private SurfaceView nonFullScreenView;
65+
@Nullable private SurfaceView fullscreenView;
66+
@Nullable private SurfaceView nonFullscreenView;
6767
@Nullable private SurfaceView currentOutputView;
6868

6969
@Nullable private static ExoPlayer player;
@@ -75,13 +75,13 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
7575
super.onCreate(savedInstanceState);
7676
setContentView(R.layout.main_activity);
7777
playerControlView = findViewById(R.id.player_control_view);
78-
fullScreenView = findViewById(R.id.full_screen_view);
79-
fullScreenView.setOnClickListener(
78+
fullscreenView = findViewById(R.id.full_screen_view);
79+
fullscreenView.setOnClickListener(
8080
v -> {
81-
setCurrentOutputView(nonFullScreenView);
82-
Assertions.checkNotNull(fullScreenView).setVisibility(View.GONE);
81+
setCurrentOutputView(nonFullscreenView);
82+
Assertions.checkNotNull(fullscreenView).setVisibility(View.GONE);
8383
});
84-
attachSurfaceListener(fullScreenView);
84+
attachSurfaceListener(fullscreenView);
8585
isOwner = getIntent().getBooleanExtra(OWNER_EXTRA, /* defaultValue= */ true);
8686
GridLayout gridLayout = findViewById(R.id.grid_layout);
8787
for (int i = 0; i < 9; i++) {
@@ -97,8 +97,8 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
9797
button.setText(getString(R.string.full_screen_label));
9898
button.setOnClickListener(
9999
v -> {
100-
setCurrentOutputView(fullScreenView);
101-
Assertions.checkNotNull(fullScreenView).setVisibility(View.VISIBLE);
100+
setCurrentOutputView(fullscreenView);
101+
Assertions.checkNotNull(fullscreenView).setVisibility(View.VISIBLE);
102102
});
103103
} else if (i == 2) {
104104
Button button = new Button(/* context= */ this);
@@ -116,10 +116,10 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {
116116
surfaceView.setOnClickListener(
117117
v -> {
118118
setCurrentOutputView(surfaceView);
119-
nonFullScreenView = surfaceView;
119+
nonFullscreenView = surfaceView;
120120
});
121-
if (nonFullScreenView == null) {
122-
nonFullScreenView = surfaceView;
121+
if (nonFullscreenView == null) {
122+
nonFullscreenView = surfaceView;
123123
}
124124
}
125125
gridLayout.addView(view);
@@ -144,7 +144,7 @@ public void onResume() {
144144
initializePlayer();
145145
}
146146

147-
setCurrentOutputView(nonFullScreenView);
147+
setCurrentOutputView(nonFullscreenView);
148148

149149
LegacyPlayerControlView playerControlView = Assertions.checkNotNull(this.playerControlView);
150150
playerControlView.setPlayer(player);

‎libraries/ui/src/main/java/androidx/media3/ui/PlayerControlView.java

+46-46
Original file line numberDiff line numberDiff line change
@@ -390,8 +390,8 @@ public interface OnFullScreenModeChangedListener {
390390
@Nullable private final ImageView shuffleButton;
391391
@Nullable private final ImageView vrButton;
392392
@Nullable private final ImageView subtitleButton;
393-
@Nullable private final ImageView fullScreenButton;
394-
@Nullable private final ImageView minimalFullScreenButton;
393+
@Nullable private final ImageView fullscreenButton;
394+
@Nullable private final ImageView minimalFullscreenButton;
395395
@Nullable private final View settingsButton;
396396
@Nullable private final View playbackSpeedButton;
397397
@Nullable private final View audioTrackButton;
@@ -422,10 +422,10 @@ public interface OnFullScreenModeChangedListener {
422422
private final Drawable subtitleOffButtonDrawable;
423423
private final String subtitleOnContentDescription;
424424
private final String subtitleOffContentDescription;
425-
private final Drawable fullScreenExitDrawable;
426-
private final Drawable fullScreenEnterDrawable;
427-
private final String fullScreenExitContentDescription;
428-
private final String fullScreenEnterContentDescription;
425+
private final Drawable fullscreenExitDrawable;
426+
private final Drawable fullscreenEnterDrawable;
427+
private final String fullscreenExitContentDescription;
428+
private final String fullscreenEnterContentDescription;
429429

430430
@Nullable private Player player;
431431
@Nullable private ProgressUpdateListener progressUpdateListener;
@@ -434,7 +434,7 @@ public interface OnFullScreenModeChangedListener {
434434
@Nullable
435435
private OnFullScreenModeChangedListener onFullScreenModeChangedListener;
436436

437-
private boolean isFullScreen;
437+
private boolean isFullscreen;
438438
private boolean isAttachedToWindow;
439439
private boolean showMultiWindowTimeBar;
440440
private boolean showPlayButtonIfSuppressed;
@@ -485,8 +485,8 @@ public PlayerControlView(
485485
int fastForwardDrawableResId = R.drawable.exo_styled_controls_simple_fastforward;
486486
int previousDrawableResId = R.drawable.exo_styled_controls_previous;
487487
int rewindDrawableResId = R.drawable.exo_styled_controls_simple_rewind;
488-
int fullScreenExitDrawableResId = R.drawable.exo_styled_controls_fullscreen_exit;
489-
int fullScreenEnterDrawableResId = R.drawable.exo_styled_controls_fullscreen_enter;
488+
int fullscreenExitDrawableResId = R.drawable.exo_styled_controls_fullscreen_exit;
489+
int fullscreenEnterDrawableResId = R.drawable.exo_styled_controls_fullscreen_enter;
490490
int repeatOffDrawableResId = R.drawable.exo_styled_controls_repeat_off;
491491
int repeatOneDrawableResId = R.drawable.exo_styled_controls_repeat_one;
492492
int repeatAllDrawableResId = R.drawable.exo_styled_controls_repeat_all;
@@ -531,12 +531,12 @@ public PlayerControlView(
531531
a.getResourceId(R.styleable.PlayerControlView_previous_icon, previousDrawableResId);
532532
rewindDrawableResId =
533533
a.getResourceId(R.styleable.PlayerControlView_rewind_icon, rewindDrawableResId);
534-
fullScreenExitDrawableResId =
534+
fullscreenExitDrawableResId =
535535
a.getResourceId(
536-
R.styleable.PlayerControlView_fullscreen_exit_icon, fullScreenExitDrawableResId);
537-
fullScreenEnterDrawableResId =
536+
R.styleable.PlayerControlView_fullscreen_exit_icon, fullscreenExitDrawableResId);
537+
fullscreenEnterDrawableResId =
538538
a.getResourceId(
539-
R.styleable.PlayerControlView_fullscreen_enter_icon, fullScreenEnterDrawableResId);
539+
R.styleable.PlayerControlView_fullscreen_enter_icon, fullscreenEnterDrawableResId);
540540
repeatOffDrawableResId =
541541
a.getResourceId(R.styleable.PlayerControlView_repeat_off_icon, repeatOffDrawableResId);
542542
repeatOneDrawableResId =
@@ -605,10 +605,10 @@ public PlayerControlView(
605605
subtitleButton.setOnClickListener(componentListener);
606606
}
607607

608-
fullScreenButton = findViewById(R.id.exo_fullscreen);
609-
initializeFullScreenButton(fullScreenButton, this::onFullScreenButtonClicked);
610-
minimalFullScreenButton = findViewById(R.id.exo_minimal_fullscreen);
611-
initializeFullScreenButton(minimalFullScreenButton, this::onFullScreenButtonClicked);
608+
fullscreenButton = findViewById(R.id.exo_fullscreen);
609+
initializeFullscreenButton(fullscreenButton, this::onFullscreenButtonClicked);
610+
minimalFullscreenButton = findViewById(R.id.exo_minimal_fullscreen);
611+
initializeFullscreenButton(minimalFullscreenButton, this::onFullscreenButtonClicked);
612612

613613
settingsButton = findViewById(R.id.exo_settings);
614614
if (settingsButton != null) {
@@ -768,16 +768,16 @@ public PlayerControlView(
768768

769769
playButtonDrawable = getDrawable(context, resources, playDrawableResId);
770770
pauseButtonDrawable = getDrawable(context, resources, pauseDrawableResId);
771-
fullScreenExitDrawable = getDrawable(context, resources, fullScreenExitDrawableResId);
772-
fullScreenEnterDrawable = getDrawable(context, resources, fullScreenEnterDrawableResId);
771+
fullscreenExitDrawable = getDrawable(context, resources, fullscreenExitDrawableResId);
772+
fullscreenEnterDrawable = getDrawable(context, resources, fullscreenEnterDrawableResId);
773773
repeatOffButtonDrawable = getDrawable(context, resources, repeatOffDrawableResId);
774774
repeatOneButtonDrawable = getDrawable(context, resources, repeatOneDrawableResId);
775775
repeatAllButtonDrawable = getDrawable(context, resources, repeatAllDrawableResId);
776776
shuffleOnButtonDrawable = getDrawable(context, resources, shuffleOnDrawableResId);
777777
shuffleOffButtonDrawable = getDrawable(context, resources, shuffleOffDrawableResId);
778-
fullScreenExitContentDescription =
778+
fullscreenExitContentDescription =
779779
resources.getString(R.string.exo_controls_fullscreen_exit_description);
780-
fullScreenEnterContentDescription =
780+
fullscreenEnterContentDescription =
781781
resources.getString(R.string.exo_controls_fullscreen_enter_description);
782782
repeatOffButtonContentDescription =
783783
resources.getString(R.string.exo_controls_repeat_off_description);
@@ -1114,8 +1114,8 @@ public void setTimeBarMinUpdateInterval(int minUpdateIntervalMs) {
11141114
public void setOnFullScreenModeChangedListener(
11151115
@Nullable OnFullScreenModeChangedListener listener) {
11161116
onFullScreenModeChangedListener = listener;
1117-
updateFullScreenButtonVisibility(fullScreenButton, listener != null);
1118-
updateFullScreenButtonVisibility(minimalFullScreenButton, listener != null);
1117+
updateFullscreenButtonVisibility(fullscreenButton, listener != null);
1118+
updateFullscreenButtonVisibility(minimalFullscreenButton, listener != null);
11191119
}
11201120

11211121
/**
@@ -1574,8 +1574,8 @@ private void seekToTimeBarPosition(Player player, long positionMs) {
15741574
updateProgress();
15751575
}
15761576

1577-
private void onFullScreenButtonClicked(View v) {
1578-
updateIsFullscreen(!isFullScreen);
1577+
private void onFullscreenButtonClicked(View v) {
1578+
updateIsFullscreen(!isFullscreen);
15791579
}
15801580

15811581
/**
@@ -1589,30 +1589,30 @@ private void onFullScreenButtonClicked(View v) {
15891589
* @param isFullscreen If the view is in full screen.
15901590
*/
15911591
public void updateIsFullscreen(boolean isFullscreen) {
1592-
if (this.isFullScreen == isFullscreen) {
1592+
if (this.isFullscreen == isFullscreen) {
15931593
return;
15941594
}
15951595

1596-
this.isFullScreen = isFullscreen;
1597-
updateFullScreenButtonForState(fullScreenButton, isFullscreen);
1598-
updateFullScreenButtonForState(minimalFullScreenButton, isFullscreen);
1596+
this.isFullscreen = isFullscreen;
1597+
updateFullscreenButtonForState(fullscreenButton, isFullscreen);
1598+
updateFullscreenButtonForState(minimalFullscreenButton, isFullscreen);
15991599

16001600
if (onFullScreenModeChangedListener != null) {
16011601
onFullScreenModeChangedListener.onFullScreenModeChanged(isFullscreen);
16021602
}
16031603
}
16041604

1605-
private void updateFullScreenButtonForState(
1606-
@Nullable ImageView fullScreenButton, boolean isFullScreen) {
1607-
if (fullScreenButton == null) {
1605+
private void updateFullscreenButtonForState(
1606+
@Nullable ImageView fullscreenButton, boolean isFullscreen) {
1607+
if (fullscreenButton == null) {
16081608
return;
16091609
}
1610-
if (isFullScreen) {
1611-
fullScreenButton.setImageDrawable(fullScreenExitDrawable);
1612-
fullScreenButton.setContentDescription(fullScreenExitContentDescription);
1610+
if (isFullscreen) {
1611+
fullscreenButton.setImageDrawable(fullscreenExitDrawable);
1612+
fullscreenButton.setContentDescription(fullscreenExitContentDescription);
16131613
} else {
1614-
fullScreenButton.setImageDrawable(fullScreenEnterDrawable);
1615-
fullScreenButton.setContentDescription(fullScreenEnterContentDescription);
1614+
fullscreenButton.setImageDrawable(fullscreenEnterDrawable);
1615+
fullscreenButton.setContentDescription(fullscreenEnterContentDescription);
16161616
}
16171617
}
16181618

@@ -1775,23 +1775,23 @@ private static boolean canShowMultiWindowTimeBar(Player player, Timeline.Window
17751775
return true;
17761776
}
17771777

1778-
private static void initializeFullScreenButton(View fullScreenButton, OnClickListener listener) {
1779-
if (fullScreenButton == null) {
1778+
private static void initializeFullscreenButton(View fullscreenButton, OnClickListener listener) {
1779+
if (fullscreenButton == null) {
17801780
return;
17811781
}
1782-
fullScreenButton.setVisibility(GONE);
1783-
fullScreenButton.setOnClickListener(listener);
1782+
fullscreenButton.setVisibility(GONE);
1783+
fullscreenButton.setOnClickListener(listener);
17841784
}
17851785

1786-
private static void updateFullScreenButtonVisibility(
1787-
@Nullable View fullScreenButton, boolean visible) {
1788-
if (fullScreenButton == null) {
1786+
private static void updateFullscreenButtonVisibility(
1787+
@Nullable View fullscreenButton, boolean visible) {
1788+
if (fullscreenButton == null) {
17891789
return;
17901790
}
17911791
if (visible) {
1792-
fullScreenButton.setVisibility(VISIBLE);
1792+
fullscreenButton.setVisibility(VISIBLE);
17931793
} else {
1794-
fullScreenButton.setVisibility(GONE);
1794+
fullscreenButton.setVisibility(GONE);
17951795
}
17961796
}
17971797

‎libraries/ui/src/main/java/androidx/media3/ui/PlayerView.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -208,10 +208,10 @@ public interface FullscreenButtonClickListener {
208208
/**
209209
* Called when the fullscreen button is clicked.
210210
*
211-
* @param isFullScreen {@code true} if the video rendering surface should be fullscreen, {@code
211+
* @param isFullscreen {@code true} if the video rendering surface should be fullscreen, {@code
212212
* false} otherwise.
213213
*/
214-
void onFullscreenButtonClick(boolean isFullScreen);
214+
void onFullscreenButtonClick(boolean isFullscreen);
215215
}
216216

217217
/**
@@ -1957,9 +1957,9 @@ public void onVisibilityChange(int visibility) {
19571957
// PlayerControlView.OnFullScreenModeChangedListener implementation
19581958

19591959
@Override
1960-
public void onFullScreenModeChanged(boolean isFullScreen) {
1960+
public void onFullScreenModeChanged(boolean isFullscreen) {
19611961
if (fullscreenButtonClickListener != null) {
1962-
fullscreenButtonClickListener.onFullscreenButtonClick(isFullScreen);
1962+
fullscreenButtonClickListener.onFullscreenButtonClick(isFullscreen);
19631963
}
19641964
}
19651965
}

0 commit comments

Comments
 (0)
Please sign in to comment.