Cleanup various things

- Reduce visiblity
- Delete unneeded test
- @ignore test that can only pass with the secret
- Start running check task

Author: liutikas

.github/workflows/build.yml

@@ -21,4 +21,4 @@ jobs:
     - name: Setup Gradle
       uses: gradle/gradle-build-action@v2
     - name: Execute Gradle build
-      run: ./gradlew jar functionalTest
+      run: ./gradlew jar check

gcpbuildcache/src/functionalTest/kotlin/androidx/build/gradle/gcpbuildcache/GcpGradleBuildCachePluginFunctionalTest.kt

@@ -35,7 +35,8 @@ class GcpGradleBuildCachePluginFunctionalTest {
     private fun getBuildFile() = getProjectDir().resolve("build.gradle.kts")
     private fun getSettingsFile() = getProjectDir().resolve("settings.gradle.kts")
 
-    @Test fun `can run tasks task`() {
+    @Test
+    fun `can run tasks task`() {
         // Setup the test build
         getSettingsFile().writeText("""
             plugins {
@@ -56,6 +57,6 @@ class GcpGradleBuildCachePluginFunctionalTest {
         runner.withPluginClasspath()
         runner.withArguments("tasks")
         runner.withProjectDir(getProjectDir())
-        val result = runner.build();
+        runner.build();
     }
 }

gcpbuildcache/src/main/kotlin/androidx/build/gradle/gcpbuildcache/FileSystemStorageService.kt

@@ -24,7 +24,7 @@ import java.nio.file.Files
 /**
  * An implementation of the [StorageService] that is backed by a file system.
  */
-class FileSystemStorageService(
+internal class FileSystemStorageService(
     override val projectId: String,
     override val bucketName: String,
     override val isPush: Boolean

gcpbuildcache/src/main/kotlin/androidx/build/gradle/gcpbuildcache/GcpBuildCacheService.kt

@@ -31,7 +31,7 @@ import java.io.ByteArrayOutputStream
  * @param bucketName The name of the bucket that is used to store all the gradle cache entries.
  * This essentially becomes the root of all cache entries.
  */
-class GcpBuildCacheService(
+internal class GcpBuildCacheService(
     private val projectId: String,
     private val bucketName: String,
     private val isPush: Boolean,

gcpbuildcache/src/main/kotlin/androidx/build/gradle/gcpbuildcache/GcpBuildCacheServiceFactory.kt

@@ -20,7 +20,7 @@ package androidx.build.gradle.gcpbuildcache
 import org.gradle.caching.BuildCacheService
 import org.gradle.caching.BuildCacheServiceFactory
 
-class GcpBuildCacheServiceFactory : BuildCacheServiceFactory<GcpBuildCache> {
+internal class GcpBuildCacheServiceFactory : BuildCacheServiceFactory<GcpBuildCache> {
     override fun createBuildCacheService(
         buildCache: GcpBuildCache,
         describer: BuildCacheServiceFactory.Describer,

gcpbuildcache/src/main/kotlin/androidx/build/gradle/gcpbuildcache/GcpStorageService.kt

@@ -31,7 +31,7 @@ import java.nio.channels.Channels
 /**
  * An implementation of the [StorageService] that is backed by Google Cloud Storage.
  */
-class GcpStorageService(
+internal class GcpStorageService(
     override val projectId: String,
     override val bucketName: String,
     override val isPush: Boolean

gcpbuildcache/src/test/kotlin/androidx/build/gradle/gcpbuildcache/GcpGradleBuildCachePluginTest.kt

@@ -17,8 +17,10 @@
 
 package androidx.build.gradle.gcpbuildcache
 
+import org.junit.Ignore
 import org.junit.Test
 
+@Ignore // These can only run with GRADLE_CACHE_SERVICE_ACCOUNT_PATH set
 class GcpStorageServiceTest {
     @Test
     fun testStoreBlob() {