Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical paper - use case description for SI #51

Open
anerv opened this issue Nov 15, 2024 · 13 comments
Open

Technical paper - use case description for SI #51

anerv opened this issue Nov 15, 2024 · 13 comments
Assignees
Labels
help wanted Extra attention is needed paper todos for research article

Comments

@anerv
Copy link
Collaborator

anerv commented Nov 15, 2024

No description provided.

@anerv anerv added the paper todos for research article label Nov 15, 2024
@anastassiavybornova
Copy link
Owner

👀

@anastassiavybornova
Copy link
Owner

@anerv a (very!) first draft of the SI is ready for you to check. plots are more like place holders for now, using them just to illustrate what my general idea of the SI would be - i.e., explaining for each layer/evaluation step (ordered in the same way as Table 1) how the information provided by the BikeNodePlanner can be helpful in revising the network. happy to get your thoughts on the general structure, and then figure out together how to distribute the polishing of each SI subsection.

@anastassiavybornova anastassiavybornova added the help wanted Extra attention is needed label Nov 19, 2024
@anastassiavybornova
Copy link
Owner

anastassiavybornova commented Nov 19, 2024

SI todos:

  • move SI to separate .tex file, add authors, affiliations etc.
  • add DKNT references in SI @anerv
  • add motivation (couple of sentences) for each subsection - based on handbog? @anerv
  • play around with seaborn (and others?) to get a better palette for evaluation layers (ideally, where nature "happens" to be green, etc) (picking happens in
    layercolors = sns.color_palette("colorblind", len(layernames))
    )
  • check disconnected components in Fyn - why? @anastassiavybornova
  • Add legends to SI figures
  • reference SI-figures from main document
  • Update figures in SI with new colors

@anerv thanks for the SI revision! little to do list above, i added our names where it made sense for me, and the rest is up for grabs, i hope to finish this by the end of the week so we can show it to the others :)

@anerv
Copy link
Collaborator Author

anerv commented Nov 19, 2024

  • Should each figure in SI be referenced from the main file?

@anastassiavybornova
Copy link
Owner

Should each figure in SI be referenced from the main file?

i think since it's a short paper, the current solution (manually writing out the reference when we use smth from main in si) is good enough, yes! (like: "Table 1 from the main text". or maybe i misunderstood what you mean)

@anerv
Copy link
Collaborator Author

anerv commented Nov 20, 2024 via email

@anerv
Copy link
Collaborator Author

anerv commented Nov 26, 2024

@anastassiavybornova for the color selection, isn't it okay that the colors are random if you do not provide automatic colors? But we would provide a commented out suggestion in config-colors-eval matching the default categories - and then use our own suggested colors for the plots in the paper?

I've added a list of suggested colors in the config-colors-eval (see pull request) using colors from this site: https://personal.sron.nl/~pault/

Feel free to request another solution!

@anerv
Copy link
Collaborator Author

anerv commented Nov 27, 2024

@anastassiavybornova let me know if you're okay with the suggested colors for the evaluation layers - then I'll update the plots in the SI and main document

@anastassiavybornova
Copy link
Owner

Hi! @anerv sorry for the late reply on this!! Yes, that's great with the color suggestion & the plot updating :)

@anastassiavybornova
Copy link
Owner

oh and:

usually there should be a in text reference to all figures - so whether we should enforce that or not :)

i would say yes!

@anastassiavybornova
Copy link
Owner

@anerv

check disconnected components in Fyn - why? @anastassiavybornova

resolved by #66 :)

i've also updated the disconnected component plot in the overleaf, but i think it needs another revision round from you (limiting the study area extent for figure 2 in main, and adding the legend for the fig in SI? for both, i'm not sure how you went about it, but let me know and i can also take care of it!)

@anerv
Copy link
Collaborator Author

anerv commented Nov 29, 2024

I can take care of the SI - it is just manual clipping together screenshots so nothing fancy there.
For the automatically generated plots in main, it looks like it is zoomed to the study area/the largest layer, but the data used for the components map also include Langeland (unlike the others). So it's more a question of streamlining which municipalities are included so it's the same for all plots.

I'll rerun data generation + the node planner over the weekend and update all plots accordingly, including new colors. Any preferences for whether to include Langeland or not?

@anastassiavybornova
Copy link
Owner

@anerv huge thanks!! i would include Langeland, yes (see #24 -- list of municipalities agreed on with Kirsten for the Fyn region)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed paper todos for research article
Projects
None yet
Development

No branches or pull requests

2 participants