-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable native optimization only on x64 #98
Conversation
Would you like to use the trial-and-error approach so that you won't sacrifice the possibility of applying the optimization? |
If there is a deterministic and cross-platform way to do this, I will be open to doing that. GCC has a separate set of options for different architectures. It specifies |
For Clang, I see the code for it here: Not sure why it is not enabled though |
For M1 Mac, it is under review: |
I think a cross-platform solution without user input is almost impossible. A deterministic solution is also hard given the continuous (micro)architecture innovations for different CPUs, both GCC and clang are just keep incorporating the new changes. Therefore, I think a trial-and-error approach may be a better option for guiding in this situation, ie, test the flag before applying. I've tested on my ARM machine with the As a relevant suggestion, we may set up an ARM-based environment using the Oracle A1 Instances (which says "Always Free") for better testing this project. |
Yeah, if a trial and error solution is available I am open to adding it. |
Changed #96 to reflect this. |
For GCC and clang, we can use I guess MSVC will have a similar way to test, but I don't have the environment for testing. |
Fixes #96