-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more compiler warnings by default #61
Comments
I fully agree that we should do a pass over the existing warning flags set, but I think it should be more nuanced than this. Right now I know there is some redundant flags. For example, the Another one to consider is |
Some of these warnings may only be available for C and not C++ in GCC. For example, |
more suggestions:
|
and (but only for C++) |
'-Wno-vla' seems to disable a warning? |
Many of these are already enabled. Could you find the ones that are not? |
It disallows the use of variable-length C arrays. I am wondering if this is already covered by -Wpedantic |
No it's not.
…On Wed, 5 Oct 2022, 22:22 Amin Yahyaabadi, ***@***.***> wrote:
'-Wno-vla'
It disallows the use of variable-length C arrays. I am wondering if this
is already covered by -Wpedantic
—
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABNITBAGULJJFNBSTGMDVUTWBXPO5ANCNFSM5N73VIFQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Here's my extra warnings:
Note that |
There is a repo on github with an up to date list of all warnings for gcc and clang, including only unique ones, it can be used to extract interesting warnings, diffs between versions are also available: https://github.com/pkolbus/compiler-warnings/blob/main/gcc/warnings-unique-13.txt |
There are other Clang warnings that we have not added. We have already enabled the most pedantic ones, so I think adding these will complete the list and would be beneficial.
https://clang.llvm.org/docs/DiagnosticsReference.html
Upvote & Fund
I am using Polar.sh so you can upvote and help fund this issue. The funding is received once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.
The text was updated successfully, but these errors were encountered: