Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing information on removing Monster #222

Open
PierreGuyot opened this issue Jan 5, 2025 · 0 comments
Open

Missing information on removing Monster #222

PierreGuyot opened this issue Jan 5, 2025 · 0 comments

Comments

@PierreGuyot
Copy link

PierreGuyot commented Jan 5, 2025

We're no longer using the `Bystander`, `Monster`, `Carnivore`, `Herbivore` and `Vendor` tags! Open up `components.rs` and delete them. You'll also need to delete their registration in `main.rs` and `saveload_system.rs`. Once they are gone, you will still see errors in `player.rs`; why? We used to use these tags to determine if we should attack or trade-places with an NPC. We can replace the failing code in `try_move_player` quite easily. First, remove the references to these components from your `using` statements. Then replace these two lines:

At this point in the tutorial, Monster is still used in inventory_system.
From what I see in the code repository, checks on wether the target is a monster or not have been removed silently here and here.

It should be mentioned in the text of the tutorial before the part about removing Monster.
Also, should there be a replacement check here, like testing if the target as some attributes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant