Skip to content

Commit c4af726

Browse files
committed
addressing #360
1 parent 0c49eb7 commit c4af726

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

open-codegen/opengen/builder/optimizer_builder.py

+5
Original file line numberDiff line numberDiff line change
@@ -860,6 +860,11 @@ def build(self):
860860
self.__build_python_bindings()
861861

862862
if self.__build_config.ros_config is not None:
863+
if self.__generate_not_build:
864+
self.__logger.fatal(
865+
"Do not use with_ros and with_generate_not_build_flag simultaneously")
866+
raise ValueError(
867+
"Unless the optimiser has been built, a ROS package cannot be generated")
863868
ros_builder = RosBuilder(
864869
self.__meta,
865870
self.__build_config,

open-codegen/opengen/builder/ros_builder.py

+1-4
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,7 @@ def __copy__ros_files(self):
111111
target_ros_dir, 'include', header_file_name))
112112
original_include_file = os.path.abspath(
113113
os.path.join(self.__target_dir(), header_file_name))
114-
try:
115-
shutil.copyfile(original_include_file, target_include_filename)
116-
except:
117-
pass
114+
shutil.copyfile(original_include_file, target_include_filename)
118115

119116
# 2. --- copy library file
120117
lib_file_name = 'lib' + self.__meta.optimizer_name + '.a'

0 commit comments

Comments
 (0)