Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-page-navigation can select wrong item when header is not first element #142

Open
kevindew opened this issue Sep 22, 2017 · 0 comments
Open
Labels
bug Something isn't working

Comments

@kevindew
Copy link
Member

If you have content above the first header in the page you can hit various oddities with the in-page-navigation. I'm thinking this happens because it only considers an item on page if it is at the very top of the viewport or hidden.

Example screenshot:
screen shot 2017-09-22 at 16 25 44

You can replicate by adding some text above content and then scrolling the page (probably quickly as I imagine the debounced events are a factor in this)

This is referenced in https://github.com/alphagov/tech-docs-template/issues/110 but before we knew that the problem was elements before the header and I felt it was better

@NickColley NickColley transferred this issue from alphagov/tech-docs-template Nov 1, 2019
@NickColley NickColley added the bug Something isn't working label Nov 1, 2019
@NickColley NickColley added this to the In page navigation bugs milestone Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants