-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish the package for Pulsar Editor #159
Comments
I'd like to add on, as one of the maintainers of Pulsar, and lead developers of the backend, I'd be more than happy to assist sorting out any troubles you have publishing, so feel free to give me a ping if needed |
Can you point me to a guide for how to package for Pulsar? I've now installed it and read some docs, but couldn't find a publishing guide. |
@alexrudd2 Thanks a ton for adding me to the project! But sure, here's our most up to date docs on publishing to the PPR. But it might be a little funkier then implied by those docs. Essentially, there's two things to keep in mind:
This does mean, that PPM needs some way to interact with Git on your system and your GitHub account. (Ideally, if you have an existing git installation, it should just use that if memory serves), then it will need your Pulsar Account API key to publish to Pulsar. I know it's a bit weird needing both, but unfortunately Pulsar isn't a part of GitHub anymore, so we can't get away with that like Atom did. To create your Pulsar account to get your Pulsar Account API Token, just go to the frontend's signup page. Although if you'd like the "advanced" way to publish, which doesn't require installing Pulsar at all:
If you are publishing the package for the first time (like we are here) then you're request will look something like:
And from there you should be good to go. But feel free to use whatever method you're more comfortable with |
Or, for the reasons you've added me to the repo, I'd be more than happy to take care of this for you, if you'd like |
So if you'd like me to handle it just let me know (or even react to this message) and I'll take care of it |
Sure, go for it. It'll take me a while to actually learn the codebase and become a "proper" maintainer, anyways. |
@alexrudd2 Ah I see, well thank you. So in that case the other big question we have, is this package still shares the name of the previously existing Is there a name you prefer? Could be simple like |
Unless there's some naming convention, |
@alexrudd2 Copy that, |
Just to keep you updated, I've gone ahead and tried publishing the package to the backend, and it has lead me to discover a bug on the backend. Where it's defaulting to using the repository name rather than the name defined by the So I'll go ahead and resolve that prior to continuing, sorry about that |
@AlexWayfer It's funny you ping about this issue now, as I've finally gotten around to resolving this bug. @alexrudd2 This package has now been successfully published to the Pulsar Package Registry as I was finally able to resolve the issue after some major refactors that took me a while, but we should now be good to go here! Thanks for the extreme patience in this issue getting sorted, as well as allowing me the permissions to go ahead and sort it out. Thanks a ton! As an aside, @AlexWayfer I can't confirm based on the screenshot, but I think you may be experiencing |
@confused-Techie I can't install it 😓 2 package-card.js? [sm]:579 Installing package linter-stylelint-pulsar failed Error: Installing “[email protected]” failed. at exit (/opt/Pulsar/resources/app.asar/node_modules/settings-view/lib/package-manager.js:437:23) at exit (/opt/Pulsar/resources/app.asar/node_modules/settings-view/lib/package-manager.js:85:26) at triggerExitCallback (/opt/Pulsar/resources/app.asar/src/buffered-process.js:280:9) at /opt/Pulsar/resources/app.asar/src/buffered-process.js:301:9 at Socket.<anonymous> (/opt/Pulsar/resources/app.asar/src/buffered-process.js:169:7) at Socket.emit (events.js:327:22) at Pipe.<anonymous> (net.js:673:12) Request for package information failed: Too Many Requests (429)
|
@AlexWayfer The first issue as you mentioned you figured out, but will still elaborate on, the last part of the message shows us the issue Otherwise as for issues installing it, I was just able to successfully install But it should totally be installed, and it may be a good idea to uninstall |
No, you didn't understand the issue (my issue). Nothing was installed. I've uninstalled and reloaded the editor. Initial state: Pressing "Install" on the correct package: After around 10 seconds: |
Okay wait, @AlexWayfer I take back what I previously said. You are totally correct that it's not installable. It seems for some reason that while Pulsar is correctly attempting to install So there is a bug, not because of this package, but apparently the backend for some reason struggled with this, and seems via all the refactors recently there's been a regression the tests didn't catch. So I'll make sure to check it out as soon as I can. I'll go ahead and track this on |
Thank you very much. |
@AlexWayfer I've just seen you're new comment. Yeah I apologize I misunderstood it. But seem to have gotten to the root issue here. What that means is to fix it, either we need to push an update of this package which should fix what version the backend is attempting to use, or otherwise (and what I'd prefer) I figure out what went wrong on the backend. I'm at work currently so may be some time, but I'll use that issue for tracking of this one. Thanks a ton for pointing this issue out especially since it has a pretty high impact possibility |
@confused-Techie no problem here, we'll wait, thank you for your work on all aspects of the wonderful editor. |
Hello!
Thanks for your fork.
I've faced with issues from the original package and we've found your fork.
What do you think about publishing a separate package for Pulsar Editor, a fork of Atom Editor?
pulsar-edit/pulsar#645 (comment)
The text was updated successfully, but these errors were encountered: