CI: Treat warnings as errors

Author: albin-johansson

.github/workflows/ci.yml

@@ -55,7 +55,8 @@ jobs:
                    -DCMAKE_BUILD_TYPE=Debug \
                    -DCMAKE_CXX_STANDARD=${{matrix.CPP_VERSION}} \
                    -DBUILD_TESTS=ON \
-                   -DBUILD_EXAMPLES=ON
+                   -DBUILD_EXAMPLES=ON \
+                   -DTREAT_WARNINGS_AS_ERRORS=ON
 
       - name: Compile
         run: ninja -C build
@@ -254,7 +255,8 @@ jobs:
                    -DCMAKE_CXX_STANDARD=${{matrix.CPP_VERSION}} \
                    -DBUILD_TESTS=ON \
                    -DBUILD_EXAMPLES=ON \
-                   -DINCLUDE_AUDIO_TESTS=OFF
+                   -DINCLUDE_AUDIO_TESTS=OFF \
+                   -DTREAT_WARNINGS_AS_ERRORS=ON
 
       - name: Compile
         run: ninja -C build
@@ -366,7 +368,8 @@ jobs:
                    -DCMAKE_BUILD_TYPE=Debug `
                    -DCMAKE_CXX_STANDARD=${{matrix.CPP_VERSION}} `
                    -DBUILD_TESTS=ON `
-                   -DBUILD_EXAMPLES=ON
+                   -DBUILD_EXAMPLES=ON `
+                   -DTREAT_WARNINGS_AS_ERRORS=ON
 
       - name: Compile
         run: ninja -C build

examples/event-dispatcher/demo.cpp

@@ -10,7 +10,7 @@ using event_dispatcher = cen::event_dispatcher<cen::quit_event,
 
 void on_mouse_button_event(const cen::mouse_button_event& event)
 {
-  cen::log_info("mouse_button_event");
+  cen::log_info("mouse_button_event (x: %i, y: %i)", event.x(), event.y());
 }
 
 // Our AAA game class
@@ -58,7 +58,7 @@ class aaa_game final {
   }
 
   // Invoked for each window event
-  void on_window_event(const cen::window_event&) { cen::log_info("window_event"); }
+  void on_window_event(const cen::window_event&) {}
 };
 
 }  // namespace

src/centurion/common/logging.hpp

@@ -179,6 +179,11 @@ inline void set_priority(const log_category category, const log_priority priorit
   return SDL_MAX_LOG_MESSAGE;
 }
 
+#if defined(__GNUC__) && !defined(__clang__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wformat-security"
+#endif  // defined(__GNUC__) && !defined(__clang__)
+
 template <typename... Args>
 void log(const log_priority priority,
          const log_category category,
@@ -192,6 +197,10 @@ void log(const log_priority priority,
                  std::forward<Args>(args)...);
 }
 
+#if defined(__GNUC__) && !defined(__clang__)
+#pragma GCC diagnostic pop
+#endif  // defined(__GNUC__) && !defined(__clang__)
+
 template <typename... Args>
 void log_verbose(const log_category category, const char* fmt, Args&&... args) noexcept
 {

src/centurion/video/window.hpp

@@ -37,6 +37,7 @@
 
 #include "../common/math.hpp"
 #include "../common/primitives.hpp"
+#include "../common/utils.hpp"
 #include "../detail/owner_handle_api.hpp"
 #include "../detail/sdl_deleter.hpp"
 #include "../detail/stdlib.hpp"
@@ -208,12 +209,14 @@ class basic_window final {
 
   auto set_fullscreen(const bool enabled) noexcept -> result
   {
-    return SDL_SetWindowFullscreen(mWindow, enabled ? fullscreen : 0) == 0;
+    const auto flag_value = to_underlying(fullscreen);
+    return SDL_SetWindowFullscreen(mWindow, enabled ? flag_value : 0) == 0;
   }
 
   auto set_fullscreen_desktop(const bool enabled) noexcept -> result
   {
-    return SDL_SetWindowFullscreen(mWindow, enabled ? fullscreen_desktop : 0) == 0;
+    const auto flag_value = to_underlying(fullscreen_desktop);
+    return SDL_SetWindowFullscreen(mWindow, enabled ? flag_value : 0) == 0;
   }
 
   void set_decorated(const bool decorated) noexcept

test/unit-tests/common/math/point_test.cpp

@@ -75,8 +75,8 @@ TEST(Point, DistanceInt)
   const cen::ipoint b {357, 752};
   const auto expected = 780;
 
-  ASSERT_FLOAT_EQ(cen::distance(a, b), expected);
-  ASSERT_FLOAT_EQ(cen::distance(b, a), expected);
+  ASSERT_EQ(cen::distance(a, b), expected);
+  ASSERT_EQ(cen::distance(b, a), expected);
 }
 
 TEST(Point, DistanceFloat)