Skip to content

Commit 03b2665

Browse files
committed
refactor(docs-infra): remove redundant overrides in FakeWebContainer
This is required to fix ``` adev/shared-docs/testing/testing-helper.ts:100:12 - error TS2416: Property 'on' in type 'FakeWebContainer' is not assignable to the same property in base type 'WebContainer'. Type '{ (event: "port", listener: PortListener): Unsubscribe; (event: "server-ready", listener: ServerReadyListener): Unsubscribe; (event: "error", listener: ErrorListener): Unsubscribe; (event: "preview-message", listener: PreviewMessageListener): Unsubscribe; }' is not assignable to type '{ (event: "port", listener: PortListener): Unsubscribe; (event: "server-ready", listener: ServerReadyListener): Unsubscribe; (event: "preview-message", listener: PreviewMessageListener): Unsubscribe; (event: "error", listener: ErrorListener): Unsubscribe; (event: "xdg-open", listener: OpenListener): Unsubscribe; (ev...'. Types of parameters 'event' and 'event' are incompatible. Type '"xdg-open"' is not assignable to type '"port"'. 100 override on(event: 'server-ready', listener: ServerReadyListener): Unsubscribe; ~~ ``` See: https://github.com/angular/angular/actions/runs/14098789522/job/39491059550?pr=60526
1 parent 7499b74 commit 03b2665

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

adev/shared-docs/testing/testing-helper.ts

+2-4
Original file line numberDiff line numberDiff line change
@@ -96,13 +96,11 @@ export class FakeWebContainer extends WebContainer {
9696

9797
return Promise.resolve(fakeProcess);
9898
}
99-
override on(event: 'port', listener: PortListener): Unsubscribe;
100-
override on(event: 'server-ready', listener: ServerReadyListener): Unsubscribe;
101-
override on(event: 'error', listener: ErrorListener): Unsubscribe;
102-
override on(event: 'preview-message', listener: PreviewMessageListener): Unsubscribe;
99+
103100
override on(event: unknown, listener: unknown): Unsubscribe {
104101
return () => {};
105102
}
103+
106104
override mount(
107105
tree: FileSystemTree,
108106
options?: {mountPoint?: string | undefined} | undefined,

0 commit comments

Comments
 (0)