Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithCustomSerializer needs to add ability to specify serialization identifier #196

Open
Aaronontheweb opened this issue Jan 26, 2023 · 1 comment
Labels
akka-actor Core Akka.NET configuration options bug Something isn't working

Comments

@Aaronontheweb
Copy link
Member

Version Information
Version of Akka.NET? 1.0.1
Which Akka.NET Modules? Akka.Hosting

Describe the bug

One thing that Akka.Hosting can't currently do is specify the akka.actor.serialization-identifiers section of HOCON:

akka.actor{
   # This is to get the manifest back in the event journal
            serializers {
              json2 = "JsonSerializerWithManifest, MyInfrastructure"
            }

            serialization-bindings {
              "System.Object" = json2
            }

            serialization-identifiers {
              "JsonSerializerWithManifest, MyInfrastructure" = 410
            }
}

With the current WithCustomerSerializer method we can't specify this - instead we have to rely on the serializer hard-coding it by overriding the Serializer.Identifer property

.WithCustomSerializer("json2", new[]{ typeof(object) }, system => new JsonSerializerWithManifest(system))
@Aaronontheweb Aaronontheweb added bug Something isn't working akka-actor Core Akka.NET configuration options labels Jan 26, 2023
@Aaronontheweb Aaronontheweb added this to the Akka.Hosting 1.0.2 milestone Jan 26, 2023
@Aaronontheweb
Copy link
Member Author

Hmm, this is going to require an Akka.NET update (to SerializerDetails) or a HOCON work-around...

@Aaronontheweb Aaronontheweb removed this from the Akka.Hosting 1.0.2 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akka-actor Core Akka.NET configuration options bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant