Skip to content

Commit be32d63

Browse files
dgp1130thePunderWoman
authored andcommitted
docs: update zip command and link to recent DevTools commits (angular#59792)
`-x dist/` never worked for reasons I don't really understand. Historically I've just deleted `dist/` before zipping. I tried a few different approaches, but all of them lead to some form of "Name not matched" error in `zip` of the `dist/` directory. Instead I just opted to delete `dist/` as part of the zipping command. The link to recent DevTools commits seems good enough to manually write a changelog. All relevant commits should be using `refactor(devtools)`, so the string "devtools" should definitely be in there. PR Close angular#59792
1 parent 751dc4a commit be32d63

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

devtools/docs/release.md

+11-5
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,20 @@ Then upload it:
6868
1. Set up Google Authenticator with the 2FA QR code.
6969
* You can find the QR code [on Valentine as well](http://valentine/#/show/1651792043556329)
7070

71-
The Firefox publishing process is slightly more involved than Chrome. In particular, they
72-
require extension source code with instructions to build and run it. Since DevTools exists in
73-
a monorepo with critical build tooling existing outside the `devtools/` directory, we need to
74-
upload the entire monorepo. Package it without dependencies and generated files with the
71+
The Firefox publishing process is slightly more involved than Chrome.
72+
73+
Mozilla asks for a changelog, which needs to be authored manually. You can search for recent
74+
`devtools` commits to see what has landed since the last release.
75+
76+
https://github.com/search?q=repo%3Aangular%2Fangular+devtools&type=commits&s=committer-date&o=desc
77+
78+
Mozilla also requires extension source code with instructions to build and run it. Since DevTools
79+
exists in a monorepo with critical build tooling existing outside the `devtools/` directory, we
80+
need to upload the entire monorepo. Package it without dependencies and generated files with the
7581
following command and upload it.
7682

7783
```shell
78-
zip -r ~/angular-source.zip * -x ".git/*" -x "node_modules/*" -x "**/node_modules/*" -x "dist/"
84+
rm -rf dist/ && zip -r ~/angular-source.zip * -x ".git/*" -x "node_modules/*" -x "**/node_modules/*"
7985
```
8086

8187
Suggested note to reviewer:

0 commit comments

Comments
 (0)