Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive permission requests #2

Open
bestpika opened this issue Dec 5, 2024 · 1 comment
Open

Excessive permission requests #2

bestpika opened this issue Dec 5, 2024 · 1 comment

Comments

@bestpika
Copy link

bestpika commented Dec 5, 2024

When I clicked login, I found that this application requested repo permissions, but the application doesn't need this permission to function.
Can you explain why?
If you just want to read whether this repo is starred, you don't need this permission at all.
image

@bestpika
Copy link
Author

bestpika commented Dec 5, 2024

return {
githubUrl: `https://github.com/login/oauth/authorize?client_id=${clientId}&scope=user:email public_repo`,
};
}

https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/scopes-for-oauth-apps
According to the official OAuth instructions, you don't even need to obtain any other information (including email) to check whether the logged-in account has starred this project.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant