fix(postgresql): no valid backups for read replica (#791)

Author: byashimov

.github/workflows/tests.yml

@@ -40,6 +40,7 @@ jobs:
     needs: [setup_aiven_project_suffix, find_tests]
     runs-on: ubuntu-latest
     strategy:
+      fail-fast: false
       max-parallel: 5
       matrix:
         name: ${{ fromJson(needs.find_tests.outputs.matrix) }}

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## [MAJOR.MINOR.PATCH] - YYYY-MM-DD
 
+- Fix `PostgreSQL`: wait for a valid backup to create read replica
+- Fix `ClickhouseGrant`: grant privileges for an unknown table (Clickhouse can do that)
+- Fix `ClickhouseGrant`: track the state to revoke only known privileges
 - Add `Cassandra` field `userConfig.cassandra.read_request_timeout_in_ms`, type `integer`: How long the
   coordinator waits for read operations to complete before timing it out
 - Add `Cassandra` field `userConfig.cassandra.write_request_timeout_in_ms`, type `integer`: How long
@@ -22,8 +25,6 @@
 - Fix `ClickhouseGrant` invalid remote and local privileges comparison
 - Fix `ClickhouseGrant`: doesn't escape role name to grant
 - Fix `ClickhouseUser`: password was reset due to an incorrect processing cycle
-- Fix `ClickhouseGrant`: grant privileges for an unknown table (Clickhouse can do that)
-- Fix `ClickhouseGrant`: track the state to revoke only known privileges
 
 ## v0.22.0 - 2024-07-02
 

controllers/generic_service_handler.go

@@ -236,6 +236,12 @@ func (h *genericServiceHandler) checkPreconditions(ctx context.Context, avn *aiv
 			if !r || err != nil {
 				return false, err
 			}
+
+			// Covers error "No valid backups for service"
+			list, err := avnGen.ServiceBackupsGet(ctx, spec.Project, s.SourceServiceName)
+			if len(list) == 0 || err != nil {
+				return false, err
+			}
 		}
 	}
 	return true, nil

tests/kafkschemaregistryaacl_test.go

@@ -101,7 +101,7 @@ func TestKafkaSchemaRegistryACL(t *testing.T) {
 	require.NoError(t, err)
 	assert.Equal(t, kafkaAvn.ServiceName, kafka.GetName())
 	assert.Equal(t, serviceRunningState, kafka.Status.State)
-	assert.EqualValues(t, kafkaAvn.State, kafka.Status.State)
+	assert.Contains(t, serviceRunningStatesAiven, string(kafkaAvn.State))
 	assert.Equal(t, kafkaAvn.Plan, kafka.Spec.Plan)
 	assert.Equal(t, kafkaAvn.CloudName, kafka.Spec.CloudName)