Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Superstruct Support (official) #282

Open
shellscape opened this issue May 15, 2023 · 3 comments
Open

[Feature]: Superstruct Support (official) #282

shellscape opened this issue May 15, 2023 · 3 comments

Comments

@shellscape
Copy link

What is the new or updated feature that you are suggesting?

Please consider adding support for superstruct https://docs.superstructjs.org/

Why should this feature be included?

superstruct is a very popular option and has been around a very long time, with proven and consistent community support and active development. superstruct comes in third in downloads https://npmtrends.com/superstruct-vs-yup-vs-zod and has crossed the 1 million weekly mark,

It's also much lighter than the alternatives https://packagephobia.com/result?p=zod vs https://packagephobia.com/result?p=superstruct and has a much smaller bundle footprint, for example: https://bundlephobia.com/package/[email protected] vs https://bundlephobia.com/package/[email protected]

superstruct is also faster than both yup and zod where it counts. https://dev.to/nicklucas/typescript-runtime-validators-and-dx-a-type-checking-performance-analysis-of-zodsuperstructyuptypebox-5416

I understand that there's an adapter pattern for the package, and it would be completely reasonable to dismiss this issue given that. however, I believe the info provided above is a compelling reason not to.

@airjp73
Copy link
Owner

airjp73 commented May 15, 2023

I'd happily take a PR adding an official superstruct adapter. It's not something I use personally, so I'm not sure I can set aside the time to implement it myself.

@shellscape
Copy link
Author

sweet. we'll see about a PR for that.

@airjp73
Copy link
Owner

airjp73 commented Sep 15, 2024

Hi! If this is something you're still interested in pursuing, there was a recent PR for a Valibot adapter that could serve as a useful template. #383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants