Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-jotform contribution from topefolorunso #45441

Merged
merged 7 commits into from
Sep 19, 2024
Merged

source-jotform contribution from topefolorunso #45441

merged 7 commits into from
Sep 19, 2024

Conversation

topefolorunso
Copy link
Collaborator

Auto-generated PR by the Connector Builder for source-jotform

@vercel Vercel
Copy link

vercel bot commented Sep 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 10:54am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 12, 2024
@natikgadzhi
Copy link
Contributor

natikgadzhi commented Sep 16, 2024 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (1f577b6)

natikgadzhi
natikgadzhi reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of docs improvements to make.

docs/integrations/sources/jotform.md Show resolved Hide resolved
docs/integrations/sources/jotform.md Outdated Show resolved Hide resolved
natikgadzhi
natikgadzhi reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata needs the api host in allowedHosts. We will infer it automatically when you make a PR soon, but for now, you'd have to do it manually on all your new connector PRs. @topefolorunso

airbyte-integrations/connectors/source-jotform/metadata.yaml Outdated Show resolved Hide resolved
@natikgadzhi natikgadzhi merged commit 367ea1d into airbytehq:master Sep 19, 2024
28 of 30 checks passed
@natikgadzhi
Copy link
Contributor

Good work @topefolorunso! 👏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi natikgadzhi left review comments

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/jotform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@topefolorunso @natikgadzhi @octavia-squidington-iii @octavia-approvington