3.11 version broke some libraries, what do you advise?

[ttodua]

For example, a popular lib CCXT has such wrapper: https://github.com/ccxt/ccxt/blob/8f5761d68a3b26387230fdb2fb5b7a8e1e881abe/python/ccxt/async_support/base/ws/fast_client.py#L86
however, since aiohttp 3.11 it errors with:

AttributeError("'aiohttp._websocket.reader_c.WebSocketReader' object attribute 'parse_frame' is read-only")

what do you suggest as a fix?

[webknjaz]

The fix is to stop relying on internal implementation details and only use public APIs 🤷‍♂️

[ttodua]

thanks for reply, that's of course, but in this very specific case, I can't find an alternative. can you name the public API that allows to hook before calling parse_frame ?

aiohttp/aiohttp/_websocket/reader_py.py

Line 323 in f46ccff

def parse_frame(

[Dreamsorcerer]

It's worth noting that the reason it fails now is because it's a C compiled version of the code now, which can provide much better performance. Given that the linked code claims to be increasing the performance of the client, it might be possible that your hacks are simply not needed anymore?

[bdraco]

If you absolutely must monkeypatch it, subclass the WebsocketReader class, patch the method you want to patch (or call super), and then patch the points where WebsocketReader is imported with your patched subclassed version. But please expect that approach to break in the future.