address breaking change introduced in aiohttp==3.9.2 #882

jakob-keller · jakob-keller · commit 99b92448c409 · 2024-01-29T18:52:59.000+01:00
diff --git a/.github/workflows/python-package.yml b/.github/workflows/python-package.yml
@@ -21,7 +21,7 @@ jobs:
       matrix:
         python-version: ['3.8', '3.9', '3.10', '3.11', '3.12']
         include:
-          - aiohttp-version: '==3.7.4.post0'
+          - aiohttp-version: '==3.9.2'
           - aiohttp-version: '<4.0.0'
             python-version: '3.11'
       fail-fast: false
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -1,8 +1,9 @@
 Changes
 -------
 
-2.11.2 (2024-01-27)
+2.12.0 (2024-01-29)
 ^^^^^^^^^^^^^^^^^^^
+* address breaking change introduced in `aiohttp==3.9.2` #882
 * fix use of proxies #1070
 
 2.11.1 (2024-01-25)
diff --git a/aiobotocore/__init__.py b/aiobotocore/__init__.py
@@ -1 +1 @@
-__version__ = '2.11.2'
+__version__ = '2.12.0'
diff --git a/aiobotocore/httpsession.py b/aiobotocore/httpsession.py
@@ -162,8 +162,7 @@ def _create_connector(self, proxy_url):
 
         return aiohttp.TCPConnector(
             limit=self._max_pool_connections,
-            verify_ssl=bool(self._verify),
-            ssl=ssl_context,
+            ssl=ssl_context or False,
             **self._connector_args,
         )
 
diff --git a/setup.py b/setup.py
@@ -8,7 +8,7 @@
 install_requires = [
     # pegged to also match items in `extras_require`
     'botocore>=1.33.2,<1.34.28',
-    'aiohttp>=3.7.4.post0,<4.0.0',
+    'aiohttp>=3.9.2,<4.0.0',
     'wrapt>=1.10.10, <2.0.0',
     'aioitertools>=0.5.1,<1.0.0',
 ]

Original file line number	Diff line number	Diff line change
`@@ -162,8 +162,7 @@ def _create_connector(self, proxy_url):`
`162`	`162`
`163`	`163`	`return aiohttp.TCPConnector(`
`164`	`164`	`limit=self._max_pool_connections,`
`165`		`- verify_ssl=bool(self._verify),`
`166`		`- ssl=ssl_context,`
	`165`	`+ ssl=ssl_context or False,`
`167`	`166`	`**self._connector_args,`
`168`	`167`	`)`
`169`	`168`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`install_requires = [`
`9`	`9`	# pegged to also match items in `extras_require`
`10`	`10`	`'botocore>=1.33.2,<1.34.28',`
`11`		`- 'aiohttp>=3.7.4.post0,<4.0.0',`
	`11`	`+ 'aiohttp>=3.9.2,<4.0.0',`
`12`	`12`	`'wrapt>=1.10.10, <2.0.0',`
`13`	`13`	`'aioitertools>=0.5.1,<1.0.0',`
`14`	`14`	`]`