Skip to content

Commit adc698c

Browse files
authored
Merge pull request #75 from Richard-Degenne/fix/ruby-3.1-freeze
Fix Ruby 3.1 #freeze
2 parents 280d4eb + 8ad69f6 commit adc698c

File tree

2 files changed

+44
-0
lines changed

2 files changed

+44
-0
lines changed

lib/recursive_open_struct.rb

+8
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,14 @@ def method_missing(mid, *args)
137137
end
138138
end
139139

140+
def freeze
141+
@table.each_key do |key|
142+
new_ostruct_member!(key)
143+
end
144+
145+
super
146+
end
147+
140148
# TODO: Rename to new_ostruct_member! once we care less about Rubies before
141149
# 2.4.0.
142150
def new_ostruct_member(name)

spec/recursive_open_struct/open_struct_behavior_spec.rb

+36
Original file line numberDiff line numberDiff line change
@@ -108,5 +108,41 @@
108108
it { expect(subject.methods.map(&:to_sym)).to_not include :asdf= }
109109
end # describe #methods
110110
end # describe handling of arbitrary attributes
111+
112+
describe "handling of freezing" do
113+
let(:hash) { { :asdf => 'John Smith' } }
114+
115+
before do
116+
ros.freeze
117+
end
118+
119+
it "can read existing keys" do
120+
expect(ros.asdf).to eq 'John Smith'
121+
end
122+
123+
it "cannot write new keys" do
124+
expect { ros.new_key = 'new_value' }.to raise_error FrozenError
125+
end
126+
127+
it "cannot write existing keys" do
128+
expect { ros.asdf = 'new_value' }.to raise_error FrozenError
129+
end
130+
131+
context "with recursive structure" do
132+
let(:hash) { { :key => { :subkey => 42 } } }
133+
134+
it "can read existing sub-elements" do
135+
expect(ros.key.subkey).to eq 42
136+
end
137+
138+
it "can write new sub-elements" do
139+
expect { ros.key.new_subkey = 43 }.not_to raise_error
140+
end
141+
142+
it "can write existing sub-elements" do
143+
expect { ros.key.subkey = 43 }.not_to raise_error
144+
end
145+
end
146+
end
111147
end # describe behavior it inherits from OpenStruct
112148
end

0 commit comments

Comments
 (0)