Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AEP-0203: remove IDENTIFIER annotation. #181

Open
toumorokoshi opened this issue Apr 27, 2024 · 0 comments
Open

AEP-0203: remove IDENTIFIER annotation. #181

toumorokoshi opened this issue Apr 27, 2024 · 0 comments

Comments

@toumorokoshi
Copy link
Member 

          I really don't like this annotation - it's very confusing, and it basically means that the behavior of the field isn't always an input.

I think there's actually a quick fix to this one - we make the field within the body of the resource always OUTPUT_ONLY, and add a field path into the Update method. Could we raise this in the next AEP meeting?

Originally posted by @toumorokoshi in #170 (comment)
@toumorokoshi toumorokoshi mentioned this issue Apr 27, 2024
Merged
11 tasks
@toumorokoshi toumorokoshi added this to the GA milestone May 20, 2024
toumorokoshi added a commit to toumorokoshi/aep.dev that referenced this issue Aug 21, 2024
@toumorokoshi
feat(update): introduce "path" variable
a33cb7e 
In protobuf, the resource path is only an input parameter in the
context of update. This has resulted in increased complexity, such as
the introduction of an `IDENTIFIER` field behavior that must be
special-cased by linters and generators.

Normalizing update to the same pattern fixes this issue.

related to aep-dev#181
@toumorokoshi toumorokoshi mentioned this issue Aug 21, 2024
Merged
7 tasks
@toumorokoshi toumorokoshi removed this from the GA milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@toumorokoshi