-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate inputs to Keras model #106
Comments
This would be an internal refactor; I don't think the user would notice any changes (at least not at first). The advantage for the user would be that this would more lightly wrap the Keras API; a lot of the code in #88's
I think (3) and (4) could be moved to checking the Keras input (after the user input has been run through the target/feature transformers). I think (2) can be enhanced with closer integration to the Keras model; there might be better error messages with |
I am just now seeing this last comment. This sounds interesting, I am +1 on anything that reduces code complexity. That said, I think this would be a fundamental departure from how Scikit-Learn does these validations? |
Currently, the number of outputs of the Keras model is checked:
scikeras/scikeras/wrappers.py
Lines 418 to 419 in 9f633f5
It'd be nice if the number of inputs could be checked too (and their shape/dtype). This should be possible according to the docs, which says a Keras Model has an
.inputs
attribute: https://keras.io/api/models/model/The text was updated successfully, but these errors were encountered: