Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing def keyword in groovy #6065

Open
llxia opened this issue Mar 18, 2025 · 2 comments
Open

Missing def keyword in groovy #6065

llxia opened this issue Mar 18, 2025 · 2 comments

Comments

@llxia
Copy link
Contributor

llxia commented Mar 18, 2025

Noticed the following warning messages in the Jenkins job.

Did you forget the `def` keyword? WorkflowScript seems to be setting a field named SPEC (to a value of type String) which could lead to memory leaks or other issues.
Did you forget the `def` keyword? WorkflowScript seems to be setting a field named dockerAgents (to a value of type ArrayList) which could lead to memory leaks or other issues.
Did you forget the `def` keyword? WorkflowScript seems to be setting a field named dockerAgentLabel (to a value of type String) which could lead to memory leaks or other issues.
Did you forget the `def` keyword? WorkflowScript seems to be setting a field named LABEL (to a value of type String) which could lead to memory leaks or other issues.
Did you forget the `def` keyword? WorkflowScript seems to be setting a field named LABEL (to a value of type String) which could lead to memory leaks or other issues.
...
Did you forget the `def` keyword? WorkflowScript seems to be setting a field named dynamicAgents (to a value of type ArrayList) which could lead to memory leaks or other issues.
@llxia
Copy link
Contributor Author

llxia commented Mar 18, 2025

@annaibm could you take a look? Thanks

annaibm added a commit to annaibm/aqa-tests that referenced this issue Mar 19, 2025
- Add def keyword to JenkinsfileBase script

related:adoptium#6065

Signed-off-by: Anna Babu Palathingal <[email protected]>
@llxia
Copy link
Contributor Author

llxia commented Mar 19, 2025

There are many cases, and I did not list them all. Please feel free to do it in a couple of batches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant