From b3aaab5847594b44d515d5dcffd22e09014ac54c Mon Sep 17 00:00:00 2001 From: Gaurav Sabharwal Date: Mon, 10 Mar 2025 11:48:00 +0530 Subject: [PATCH 1/4] bug fix for higher versions of node --- packages/create-ccweb-add-on/src/app/WxpAddOnFactory.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/create-ccweb-add-on/src/app/WxpAddOnFactory.ts b/packages/create-ccweb-add-on/src/app/WxpAddOnFactory.ts index d097133..7127674 100644 --- a/packages/create-ccweb-add-on/src/app/WxpAddOnFactory.ts +++ b/packages/create-ccweb-add-on/src/app/WxpAddOnFactory.ts @@ -175,8 +175,7 @@ export class WxpAddOnFactory implements AddOnFactory { const targetPath = path.join(addOnDirectory, TEMP_TEMPLATE_PATH); fs.ensureDirSync(targetPath); - const templateFilePath = path.join(import.meta.url, "..", "..", "templates", templateName); - const templateDirectory = url.fileURLToPath(templateFilePath); + const templateDirectory = path.join(url.fileURLToPath(import.meta.url), "..", "..", "templates", templateName); if (fs.existsSync(templateDirectory)) { fs.copySync(templateDirectory, targetPath); From 32f144af86ba02c87101e729b265bbf3d5532d1e Mon Sep 17 00:00:00 2001 From: Gaurav Sabharwal Date: Mon, 10 Mar 2025 11:49:43 +0530 Subject: [PATCH 2/4] bumping version --- packages/create-ccweb-add-on/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-ccweb-add-on/package.json b/packages/create-ccweb-add-on/package.json index cea8fe1..6d25bbf 100644 --- a/packages/create-ccweb-add-on/package.json +++ b/packages/create-ccweb-add-on/package.json @@ -1,6 +1,6 @@ { "name": "@adobe/create-ccweb-add-on", - "version": "2.4.1", + "version": "2.4.2", "author": "Adobe", "license": "MIT", "description": "Create an Adobe Creative Cloud Web Add-on.", From 18a9420671c73d223ae39c239d83452ddf484fe4 Mon Sep 17 00:00:00 2001 From: Gaurav Sabharwal Date: Mon, 10 Mar 2025 11:49:55 +0530 Subject: [PATCH 3/4] publish changes --- common/config/rush/pnpm-lock.yaml | 92 ++++++++----------------------- rush.json | 4 +- 2 files changed, 25 insertions(+), 71 deletions(-) diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml index 9c1f40a..1a3f6a6 100644 --- a/common/config/rush/pnpm-lock.yaml +++ b/common/config/rush/pnpm-lock.yaml @@ -567,28 +567,25 @@ importers: ../../packages/wxp-sdk-types: dependencies: - '@swc/helpers': - specifier: 0.5.12 - version: 0.5.12 gl-matrix: specifier: 3.3.0 version: 3.3.0 tslib: - specifier: 2.7.0 - version: 2.7.0 + specifier: 2.6.2 + version: 2.6.2 devDependencies: '@types/node': - specifier: 18.18.2 - version: 18.18.2 + specifier: 16.18.36 + version: 16.18.36 prettier: specifier: 2.8.0 version: 2.8.0 ts-node: specifier: 10.9.2 - version: 10.9.2(@types/node@18.18.2)(typescript@5.6.3) + version: 10.9.2(@types/node@16.18.36)(typescript@5.4.5) typescript: - specifier: 5.6.3 - version: 5.6.3 + specifier: 5.4.5 + version: 5.4.5 ../../packages/wxp-ssl: dependencies: @@ -1052,7 +1049,7 @@ packages: strip-ansi: 6.0.1 supports-color: 8.1.1 supports-hyperlinks: 2.3.0 - tslib: 2.7.0 + tslib: 2.6.2 widest-line: 3.1.0 wrap-ansi: 7.0.0 dev: true @@ -1085,7 +1082,7 @@ packages: supports-color: 8.1.1 supports-hyperlinks: 2.3.0 ts-node: 10.9.2(@types/node@16.18.36)(typescript@5.4.5) - tslib: 2.7.0 + tslib: 2.6.2 widest-line: 3.1.0 wordwrap: 1.0.0 wrap-ansi: 7.0.0 @@ -1384,7 +1381,7 @@ packages: /@swc/helpers@0.5.12: resolution: {integrity: sha512-KMZNXiGibsW9kvZAO1Pam2JPTDBm+KSHMMHWdsyI/1DbIZjT2A6Gy3hblVXUMEDvUAKq+e0vL0X0o54owWji7g==} dependencies: - tslib: 2.7.0 + tslib: 2.6.2 dev: false /@tootallnate/once@1.1.2: @@ -1432,7 +1429,7 @@ packages: resolution: {integrity: sha512-oyl4jvAfTGX9Bt6Or4H9ni1Z447/tQuxnZsytsCaExKlmJiU8sFgnIBRzJUpKwB5eWn9HuBYlUlVA74q/yN0eQ==} dependencies: '@types/connect': 3.4.36 - '@types/node': 18.18.2 + '@types/node': 16.18.36 dev: true /@types/chai-as-promised@7.1.3: @@ -1448,7 +1445,7 @@ packages: /@types/cli-progress@3.11.5: resolution: {integrity: sha512-D4PbNRbviKyppS5ivBGyFO29POlySLmA2HyUFE4p5QGazAMM3CwkKWcvTl8gvElSuxRh6FPKL8XmidX873ou4g==} dependencies: - '@types/node': 18.18.2 + '@types/node': 16.18.36 /@types/configstore@2.1.1: resolution: {integrity: sha512-YY+hm3afkDHeSM2rsFXxeZtu0garnusBWNG1+7MknmDWQHqcH2w21/xOU9arJUi8ch4qyFklidANLCu3ihhVwQ==} @@ -1457,7 +1454,7 @@ packages: /@types/connect@3.4.36: resolution: {integrity: sha512-P63Zd/JUGq+PdrM1lv0Wv5SBYeA2+CORvbrXbngriYY0jzLUWfQMQQxOhjONEz/wlHOAxOdY7CY65rgQdTjq2w==} dependencies: - '@types/node': 18.18.2 + '@types/node': 16.18.36 dev: true /@types/cors@2.8.12: @@ -1481,7 +1478,7 @@ packages: /@types/express-serve-static-core@4.17.37: resolution: {integrity: sha512-ZohaCYTgGFcOP7u6aJOhY9uIZQgZ2vxC2yWoArY+FeDXlqeH66ZVBjgvg+RLVAS/DWNq4Ap9ZXu1+SUQiiWYMg==} dependencies: - '@types/node': 18.18.2 + '@types/node': 16.18.36 '@types/qs': 6.9.8 '@types/range-parser': 1.2.5 '@types/send': 0.17.2 @@ -1510,14 +1507,14 @@ packages: resolution: {integrity: sha512-rTtf75rwyP9G2qO5yRpYtdJ6aU1QqEhWbtW55qEgquEDa6bXW0s2TWZfDm02GuppjEozOWG/F2UnPq5hAQb+gw==} dependencies: '@types/minimatch': 5.1.2 - '@types/node': 18.18.2 + '@types/node': 16.18.36 dev: false /@types/glob@7.2.0: resolution: {integrity: sha512-ZUxbzKl0IfJILTS6t7ip5fQQM/J3TJYubDm3nMbgubNNYS62eXeUpoLUC8/7fJNiFYHTrGPQn7hspDUzIHX3UA==} dependencies: '@types/minimatch': 5.1.2 - '@types/node': 18.18.2 + '@types/node': 16.18.36 /@types/hjson@2.4.3: resolution: {integrity: sha512-EDixutNn3FQwa5HdET+Tx0h7TirP2knJa9TB21ySqr8XVqT/VsvvOwnanTLHUOOpNofcUhkRKhOk0Wh4YD9RSA==} @@ -1552,7 +1549,7 @@ packages: /@types/mkdirp@0.5.2: resolution: {integrity: sha512-U5icWpv7YnZYGsN4/cmh3WD2onMY0aJIiTE6+51TwJCttdHvtCYmkBNOobHlXwrJRL0nkH9jH4kD+1FAdMN4Tg==} dependencies: - '@types/node': 18.18.2 + '@types/node': 16.18.36 dev: false /@types/mocha@9.1.1: @@ -1570,9 +1567,6 @@ packages: /@types/node@16.18.36: resolution: {integrity: sha512-8egDX8dE50XyXWH6C6PRCNkTP106DuUrvdrednFouDSmCi7IOvrqr0frznfZaHifHH/3aq/7a7v9N4wdXMqhBQ==} - /@types/node@18.18.2: - resolution: {integrity: sha512-u1cis+7wLZMPI62EozwsqvgMZyauczyiqRRu/vcqZKI5N5yidrJHqOFxEg5seT8adc96Q6Yczg1c0DlqGtMJMw==} - /@types/node@8.10.66: resolution: {integrity: sha512-tktOkFUA4kXx2hhhrB8bIFb5TbwzS4uOhKEmwiD+NoiL0qtP2OQ9mFldbgD4dV1djrlBYP6eBuQZiWjuHUpqFw==} dev: false @@ -1599,7 +1593,7 @@ packages: resolution: {integrity: sha512-YyP+VfeaqAyFmXoTh3HChxOQMyjByRMsHU7kc5KOJkSlXudhMhQIALbYV7rHh/l8d2lX3VUQzprrcAgWdRuU8g==} dependencies: '@types/glob': 7.2.0 - '@types/node': 18.18.2 + '@types/node': 16.18.36 dev: false /@types/semver@7.3.4: @@ -1610,7 +1604,7 @@ packages: resolution: {integrity: sha512-aAG6yRf6r0wQ29bkS+x97BIs64ZLxeE/ARwyS6wrldMm3C1MdKwCcnnEwMC1slI8wuxJOpiUH9MioC0A0i+GJw==} dependencies: '@types/mime': 1.3.3 - '@types/node': 18.18.2 + '@types/node': 16.18.36 dev: true /@types/serve-static@1.15.3: @@ -1618,7 +1612,7 @@ packages: dependencies: '@types/http-errors': 2.0.2 '@types/mime': 3.0.2 - '@types/node': 18.18.2 + '@types/node': 16.18.36 dev: true /@types/sinon-chai@3.2.10: @@ -1658,7 +1652,7 @@ packages: resolution: {integrity: sha512-vPXzCLmRp74e9LsP8oltnWKTH+jBwt86WgRUb4Pc9Lf3pkMVGyvIo2gm9bODeGfCay2DBB/hAWDuvf07JcK4rw==} dependencies: '@types/expect': 1.20.4 - '@types/node': 18.18.2 + '@types/node': 16.18.36 dev: true /@types/ws@8.5.3: @@ -2861,7 +2855,7 @@ packages: dependencies: '@types/chai': 4.2.14 '@types/lodash': 4.14.199 - '@types/node': 18.18.2 + '@types/node': 16.18.36 '@types/sinon': 9.0.8 lodash: 4.17.21 mock-stdin: 1.0.0 @@ -5332,7 +5326,7 @@ packages: /rxjs@7.8.1: resolution: {integrity: sha512-AA3TVj+0A2iuIoQkWEK/tqFjBq2j+6PO6Y0zJcvzLAFhEFIO3HL0vls9hWLncZbAAbK0mar7oZ4V079I/qPMxg==} dependencies: - tslib: 2.7.0 + tslib: 2.6.2 dev: true /safe-buffer@5.1.2: @@ -5967,37 +5961,6 @@ packages: v8-compile-cache-lib: 3.0.1 yn: 3.1.1 - /ts-node@10.9.2(@types/node@18.18.2)(typescript@5.6.3): - resolution: {integrity: sha512-f0FFpIdcHgn8zcPSbf1dRevwt047YMnaiJM3u2w2RewrB+fob/zePZcrOyQoLMMO7aBIddLcQIEK5dYjkLnGrQ==} - hasBin: true - peerDependencies: - '@swc/core': '>=1.2.50' - '@swc/wasm': '>=1.2.50' - '@types/node': '*' - typescript: '>=2.7' - peerDependenciesMeta: - '@swc/core': - optional: true - '@swc/wasm': - optional: true - dependencies: - '@cspotcode/source-map-support': 0.8.1 - '@tsconfig/node10': 1.0.9 - '@tsconfig/node12': 1.0.11 - '@tsconfig/node14': 1.0.3 - '@tsconfig/node16': 1.0.4 - '@types/node': 18.18.2 - acorn: 8.10.0 - acorn-walk: 8.2.0 - arg: 4.1.3 - create-require: 1.1.1 - diff: 4.0.2 - make-error: 1.3.6 - typescript: 5.6.3 - v8-compile-cache-lib: 3.0.1 - yn: 3.1.1 - dev: true - /ts-sinon@2.0.1: resolution: {integrity: sha512-uI5huDCY6Gw6Yczmyd/Jcu8gZZYtWO0HakPShvDmlrgcywLyFZ7lgWt1y+gd/x79ReHh+rhMAJkhQkGRnPNikw==} dependencies: @@ -6014,9 +5977,6 @@ packages: /tslib@2.6.2: resolution: {integrity: sha512-AEYxH93jGFPn/a2iVAwW87VuUIkR1FVUKB77NwMF7nBTDkDrrT/Hpt/IrCJ0QXhW27jTBDcf5ZY7w6RiqTMw2Q==} - /tslib@2.7.0: - resolution: {integrity: sha512-gLXCKdN1/j47AiHiOkJN69hJmcbGTHI0ImLmbYLHykhgeN0jVGola9yVjFgzCUklsZQMW55o+dW7IXv3RCXDzA==} - /tuf-js@1.1.7: resolution: {integrity: sha512-i3P9Kgw3ytjELUfpuKVDNBJvk4u5bXL6gskv572mcevPbSKCV3zt3djhmlEQ65yERjIbOSncy7U4cQJaB1CBCg==} engines: {node: ^14.17.0 || ^16.13.0 || >=18.0.0} @@ -6072,12 +6032,6 @@ packages: engines: {node: '>=14.17'} hasBin: true - /typescript@5.6.3: - resolution: {integrity: sha512-hjcS1mhfuyi4WW8IWtjP7brDrG2cuDZukyrYrSauoXGNgx0S7zceP07adYkJycEr56BOUTNPzbInooiN3fn1qw==} - engines: {node: '>=14.17'} - hasBin: true - dev: true - /unique-filename@1.1.1: resolution: {integrity: sha512-Vmp0jIp2ln35UTXuryvjzkjGdRyf9b2lTXuSYUiPmzRcl3FDtYqAwOnTJkAngD9SWhnoJzDbTKwaOrZ+STtxNQ==} dependencies: diff --git a/rush.json b/rush.json index ca5ec7e..f7684c6 100644 --- a/rush.json +++ b/rush.json @@ -31,7 +31,7 @@ "packageName": "@adobe/create-ccweb-add-on", "projectFolder": "packages/create-ccweb-add-on", "reviewCategory": "production", - "shouldPublish": false + "shouldPublish": true }, { "packageName": "@adobe/ccweb-add-on-scaffolder", @@ -61,7 +61,7 @@ "packageName": "@adobe/ccweb-add-on-sdk-types", "projectFolder": "packages/wxp-sdk-types", "reviewCategory": "production", - "shouldPublish": true + "shouldPublish": false } ] } From b370cfdc37e6a678c6c627050aee44a1b14eaa88 Mon Sep 17 00:00:00 2001 From: Gaurav Sabharwal Date: Mon, 10 Mar 2025 11:53:07 +0530 Subject: [PATCH 4/4] release notes --- .../release-20250310_2025-03-10-06-22.json | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 common/changes/@adobe/create-ccweb-add-on/release-20250310_2025-03-10-06-22.json diff --git a/common/changes/@adobe/create-ccweb-add-on/release-20250310_2025-03-10-06-22.json b/common/changes/@adobe/create-ccweb-add-on/release-20250310_2025-03-10-06-22.json new file mode 100644 index 0000000..dddf1a2 --- /dev/null +++ b/common/changes/@adobe/create-ccweb-add-on/release-20250310_2025-03-10-06-22.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@adobe/create-ccweb-add-on", + "comment": "bug fix - path.join expects actual path", + "type": "patch" + } + ], + "packageName": "@adobe/create-ccweb-add-on" +} \ No newline at end of file