Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom 401 view is not shown for production hosts. #495

Open
dylandepass opened this issue Mar 7, 2025 · 3 comments
Open

Custom 401 view is not shown for production hosts. #495

dylandepass opened this issue Mar 7, 2025 · 3 comments
Labels
question Further information is requested

Comments

@dylandepass
Copy link
Member

A customer is asking about having this appear on their production host. Is there a reason we excluded it @rofe?

https://github.com/adobe/aem-sidekick/blob/main/src/extension/app/utils/browser.js#L243

@dylandepass dylandepass added the question Further information is requested label Mar 7, 2025
@rofe
Copy link
Contributor

rofe commented Mar 12, 2025

@dylandepass I think we don't want customers to use this method of authentication for production (intranet/extranet) use cases or other custom hosts. It was merely meant for to allow authors to connect to preview and live if they are locked down. If customer want to built protected sites in production, they should implement that on their byoCDN using the IDP of their choice.

@davidnuescheler wdyt?

@dylandepass
Copy link
Member Author

Understood. The customer was previously using site authentication in helix 4 (in production) as a way of locking down a site for a intranet use case. So immediately getting kicked to the IDP login worked well for this. The best experience we can offer with helix 5 as you know is for the sidekick to appear and users to login there.

I do agree that this feels outside the intended use case of site authentication.

@rofe
Copy link
Contributor

rofe commented Mar 13, 2025

I don't think we should require site visitors to install the sidekick. They need to implement this differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants