Exclude MissingParentheses rule and revert the change

Author: pattisahusiwa

phpcs.xml.dist

@@ -10,8 +10,13 @@
 
   <rule ref="PSR12"/>
 
+  <rule ref="PSR12">
+    <exclude name="PSR12.Classes.ClassInstantiation.MissingParentheses" />
+  </rule>
+
   <rule ref="PSR2.Classes.PropertyDeclaration.Underscore">
-    <exclude-pattern>/src/</exclude-pattern>
+    <exclude-pattern>/src/Input/Command.php</exclude-pattern>
+    <exclude-pattern>/src/Input/Parser.php</exclude-pattern>
   </rule>
 
   <rule ref="PSR12.Properties.ConstantVisibility.NotFound">

src/Application.php

@@ -220,7 +220,7 @@ public function commandFor(array $argv): Command
     public function io(Interactor $io = null)
     {
         if ($io || !$this->io) {
-            $this->io = $io ?? new Interactor();
+            $this->io = $io ?? new Interactor;
         }
 
         if (\func_num_args() === 0) {

src/Helper/OutputHelper.php

@@ -36,7 +36,7 @@ class OutputHelper
 
     public function __construct(Writer $writer = null)
     {
-        $this->writer = $writer ?? new Writer();
+        $this->writer = $writer ?? new Writer;
     }
 
     /**

src/Input/Command.php

@@ -425,7 +425,7 @@ public function action(callable $action = null)
      */
     protected function writer(): Writer
     {
-        return $this->_app ? $this->_app->io()->writer() : new Writer();
+        return $this->_app ? $this->_app->io()->writer() : new Writer;
     }
 
     /**
@@ -435,6 +435,6 @@ protected function writer(): Writer
      */
     protected function io(): Interactor
     {
-        return $this->_app ? $this->_app->io() : new Interactor();
+        return $this->_app ? $this->_app->io() : new Interactor;
     }
 }

src/Input/Parser.php

@@ -51,7 +51,7 @@ abstract class Parser
      */
     public function parse(array $argv): self
     {
-        $this->_normalizer = new Normalizer();
+        $this->_normalizer = new Normalizer;
 
         \array_shift($argv);
 

src/Output/Writer.php

@@ -182,8 +182,8 @@ public function __construct(string $path = null, Color $colorizer = null)
         $this->stream  = $path ?: \STDOUT;
         $this->eStream = $path ?: \STDERR;
 
-        $this->cursor    = new Cursor();
-        $this->colorizer = $colorizer ?? new Color();
+        $this->cursor    = new Cursor;
+        $this->colorizer = $colorizer ?? new Color;
     }
 
     /**
@@ -286,7 +286,7 @@ public function raw($text, bool $error = false): self
      */
     public function table(array $rows, array $styles = []): self
     {
-        $table = (new Table())->render($rows, $styles);
+        $table = (new Table)->render($rows, $styles);
 
         return $this->colors($table);
     }

tests/ApplicationTest.php

@@ -221,7 +221,7 @@ public function test_io()
 
         $this->assertInstanceOf(Interactor::class, $oio = $a->io());
 
-        $a->io(new Interactor());
+        $a->io(new Interactor);
 
         $this->assertInstanceOf(Interactor::class, $a->io());
         $this->assertNotSame($oio, $a->io());

tests/Output/ColorTest.php

@@ -19,19 +19,19 @@ class ColorTest extends TestCase
     /** @dataProvider methods */
     public function test_methods($method, $color)
     {
-        $this->assertSame("\033[0;{$color}m{$method}\033[0m", (new Color())->{$method}($method));
+        $this->assertSame("\033[0;{$color}m{$method}\033[0m", (new Color)->{$method}($method));
     }
 
     public function test_comment()
     {
-        $this->assertSame("\033[2;37mcomment\033[0m", (new Color())->comment('comment'));
+        $this->assertSame("\033[2;37mcomment\033[0m", (new Color)->comment('comment'));
     }
 
     public function test_custom_style()
     {
         Color::style('alert', ['bg' => Color::YELLOW, 'fg' => Color::RED, 'bold' => 1]);
 
-        $this->assertSame("\033[1;31;43malert\033[0m", (new Color())->alert('alert'));
+        $this->assertSame("\033[1;31;43malert\033[0m", (new Color)->alert('alert'));
 
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessage('Trying to define existing style');
@@ -49,7 +49,7 @@ public function test_invalid_custom_style()
 
     public function test_colors()
     {
-        $c = new Color();
+        $c = new Color;
 
         $this->assertSame("\nabc\n", $c->colors('<eol>abc</eol>'));
         $this->assertSame("\033[0;31mRed\033[0m", $c->colors('<red>Red</end>'));
@@ -63,25 +63,25 @@ public function test_colors()
 
     public function test_magic_call()
     {
-        $this->assertSame("\033[1;37mline\033[0m", (new Color())->bold('line'));
+        $this->assertSame("\033[1;37mline\033[0m", (new Color)->bold('line'));
 
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessage('Text required');
 
-        (new Color())->bgRed();
+        (new Color)->bgRed();
     }
 
     public function test_magic_call_color()
     {
-        $this->assertSame("\033[0;35mpurple\033[0m", (new Color())->purple('purple'));
+        $this->assertSame("\033[0;35mpurple\033[0m", (new Color)->purple('purple'));
     }
 
     public function test_magic_call_invalid()
     {
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessage('Style "random" not defined');
 
-        (new Color())->random('Rand');
+        (new Color)->random('Rand');
     }
 
     public function methods()

tests/Output/CursorTest.php

@@ -20,7 +20,7 @@ public function test()
     {
         ob_start();
 
-        $c = new Cursor();
+        $c = new Cursor;
 
         echo $c->up(1) . $c->down(2) . $c->right(3) . $c->left(4) . $c->next(0) . $c->prev(2);
 
@@ -31,7 +31,7 @@ public function test_clean()
     {
         ob_start();
 
-        $c = new Cursor();
+        $c = new Cursor;
 
         echo $c->eraseLine() . $c->clear() . $c->clearUp() . $c->clearDown();
 
@@ -42,7 +42,7 @@ public function test_move()
     {
         ob_start();
 
-        $c = new Cursor();
+        $c = new Cursor;
 
         echo $c->moveTo(1, 2) . $c->moveTo(5, 8);
 

tests/Output/WriterTest.php

@@ -19,31 +19,31 @@ class WriterTest extends CliTestCase
 {
     public function test_simple_write()
     {
-        (new Writer())->write('Hey');
+        (new Writer)->write('Hey');
 
         $this->assertContains('Hey', $this->buffer());
         $this->assertSame("\033[0;37mHey\033[0m", $this->buffer());
     }
 
     public function test_write_error()
     {
-        (new Writer())->error->write('Something wrong');
+        (new Writer)->error->write('Something wrong');
 
         $this->assertContains('Something wrong', $this->buffer());
         $this->assertSame("\033[0;31mSomething wrong\033[0m", $this->buffer());
     }
 
     public function test_write_with_newline()
     {
-        (new Writer())->write('Hello', true);
+        (new Writer)->write('Hello', true);
 
         $this->assertContains('Hello', $this->buffer());
         $this->assertSame("\033[0;37mHello\033[0m" . PHP_EOL, $this->buffer());
     }
 
     public function test_write_bold_red_bggreen()
     {
-        (new Writer())->bold->red->bgGreen->write('bold->red->bgGreen');
+        (new Writer)->bold->red->bgGreen->write('bold->red->bgGreen');
 
         $this->assertContains('bold->red->bgGreen', $this->buffer());
         $this->assertSame("\033[1;31;42mbold->red->bgGreen\033[0m", $this->buffer());
@@ -106,6 +106,6 @@ public function test_table_throws()
 
     public function test_colorizer()
     {
-        $this->assertInstanceOf(Color::class, (new Writer())->colorizer());
+        $this->assertInstanceOf(Color::class, (new Writer)->colorizer());
     }
 }