Format a better error message when a bad spec is requested in a PR

AdamBrousseau · AdamBrousseau · commit 1a2ffa60a800 · 2020-01-06T15:13:02.000-05:00
[skip ci]

Signed-off-by: Adam Brousseau &lt;adam.brousseau88@gmail.com&gt;
diff --git a/buildenv/jenkins/common/pipeline-functions.groovy b/buildenv/jenkins/common/pipeline-functions.groovy
@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2017, 2019 IBM Corp. and others
+ * Copyright (c) 2017, 2020 IBM Corp. and others
  *
  * This program and the accompanying materials are made available under
  * the terms of the Eclipse Public License 2.0 which accompanies this
@@ -777,7 +777,11 @@ def setup_pull_request_single_comment(PARSED_COMMENT) {
         if (LONG_PLATFORM) {
             PLATFORMS.addAll(LONG_PLATFORM)
         } else {
-            error("Unknown PLATFORM short:'${SHORT}'\nExpected one of:${SHORT_NAMES}")
+            def shortNamesList = []
+            SHORT_NAMES.each {
+                shortNamesList.add(it.key)
+            }
+            error("Unknown PLATFORM short:'${SHORT}'\nExpected one of:${shortNamesList}")
         }
     }
     echo "PLATFORMS:'${PLATFORMS}'"

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*******************************************************************************`
`2`		`- * Copyright (c) 2017, 2019 IBM Corp. and others`
	`2`	`+ * Copyright (c) 2017, 2020 IBM Corp. and others`
`3`	`3`	`*`
`4`	`4`	`* This program and the accompanying materials are made available under`
`5`	`5`	`* the terms of the Eclipse Public License 2.0 which accompanies this`
`@@ -777,7 +777,11 @@ def setup_pull_request_single_comment(PARSED_COMMENT) {`
`777`	`777`	`if (LONG_PLATFORM) {`
`778`	`778`	`PLATFORMS.addAll(LONG_PLATFORM)`
`779`	`779`	`} else {`
`780`		`- error("Unknown PLATFORM short:'${SHORT}'\nExpected one of:${SHORT_NAMES}")`
	`780`	`+ def shortNamesList = []`
	`781`	`+ SHORT_NAMES.each {`
	`782`	`+ shortNamesList.add(it.key)`
	`783`	`+ }`
	`784`	`+ error("Unknown PLATFORM short:'${SHORT}'\nExpected one of:${shortNamesList}")`
`781`	`785`	`}`
`782`	`786`	`}`
`783`	`787`	`echo "PLATFORMS:'${PLATFORMS}'"`