DS18b20 and Pico W causing decode error

[brentru]

Describe the bug
Pico W connected to a ds18b20 is causing a crash

Arduino board
Raspberry Pi Pico W

Logs

Connecting a new DS18b20 to a Pico W, attempt #1

* NEW MESSAGE [Topic: Signal-DS]:
23 bytes.
[Message Type] Init. DS Sensor
Adding DS18x20 Component...Failed to find DSx sensor on specified pin.
Created OneWireBus on GPIO D14 with DS18x20 attached!
-> DS18x Init Response...Published!
Protobuf decode error: (none)
ERROR: Unable to decode DS message

Connecting a new DS18b20 to a Pico W, attempt #2

* NEW MESSAGE [Topic: Signal-DS]:
23 bytes.
[Message Type] Init. DS Sensor
Connection lost -- read failed: [Errno 6] Device not configured
Use Stop/Restart to reconnect.
Process ended with exit code 1.
MQTT Connection Error: -1
Connection failed
...
ERROR [WDT RESET IN -1]:
ERROR: Unable to connect to Adafruit.IO MQTT, rebooting soon...
#Pico rebooted and same message repeated over and over#

@tyeth I think this is from within the DS18 driver used on PicoW?

Connection lost -- read failed: [Errno 6] Device not configured
Use Stop/Restart to reconnect.

Which components are connected to your device
DS18b20 from Aliexpress

[brentru]

@tyeth Could you attempt to reproduce this issue this week?

[tyeth]

Will do!

[tyeth]

Just to add we may have a destructor missing issue, which presents itself when removing and adding DS18b20 devices.
Adding and removing the ds18b20 crashes on third time. Adding a PIO destructor fixes it, see
https://github.com/tyeth/pstolarz_OneWireNg/tree/pio-destructor
and
pstolarz/OneWireNg#71

Note to self, retest with fix in pstolarz/OneWireNg#71

Note to Brent, we might want to switch to the bitbanged driver for rp2040, so we can support more ds18b20 devices. There is a requirement to supply the pio number to the ds18b20 constructor, with 2 pins per pio at 4max (we might even find it crashes with 3 devices without pio num argument to constructor), whereas the bitbang implementation supports many pins (>4).

[pstolarz]

I don't recommend the bit-bang driver since it blocks interrupts during bus transmission. There are observed UART problems with PicoSDK while using the BB driver. While properly configured the PIO driver supports up to 8 object services - details how to create them will be available in the updated OneWireNg's README soon.

[tyeth]

Retested the destructor PR and works, resolves the inability to re-add DS18b20 devices to the pico.

I haven't seen the not connected / connection lost read message, so not sure if the original bug was truly recreated rather than a second symptom / bug fixed.

[brentru]

@tyeth If it works, is there a corresponding PR for this?

[brentru]

@tyeth Can we close this?

[tyeth]

I was kind of hoping to test with more than two DS18b20's, but I can only locate two currently. I think there may be issues at 5 (or 3, basically 2 per pio channel is supported) which we would like to know about in advance.

…

On Fri, 21 Feb 2025 at 19:36, Brent Rubell ***@***.***> wrote: @tyeth <https://github.com/tyeth> Can we close this? — Reply to this email directly, view it on GitHub <#677 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTBZ45V6JURRNTUH5SJQJ32Q553LAVCNFSM6AAAAABUVYLKNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZVGM4DONRTHE> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: brentru]*brentru* left a comment (adafruit/Adafruit_Wippersnapper_Arduino#677) <#677 (comment)> @tyeth <https://github.com/tyeth> Can we close this? — Reply to this email directly, view it on GitHub <#677 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABTBZ45V6JURRNTUH5SJQJ32Q553LAVCNFSM6AAAAABUVYLKNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZVGM4DONRTHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[brentru]

@pstolarz

While properly configured the PIO driver supports up to 8 object services - details how to create them will be available in the updated OneWireNg's README soon.

Thanks for the feedback! Do you have an ETA of when to expect usage for the PIO driver in the readme? I'll gladly switch to it, especially if it supports 8 objects (that's awesome work, thank you!).

[pstolarz]

@brentru It's there for some time already, see:
https://github.com/pstolarz/OneWireNg?tab=readme-ov-file#arch_rp2040pio_multi_bus

[brentru]

@tyeth So we migrated to the OneWireNG implementation instead of DallasTemperature in the v2 branch for WipperSnapper, not v1.

As a result, we won't fix this within v1 but it will be resolved within the v2 branch.

[brentru]

@tyeth The OneWireNG PIO implementation for RP2040 has been implemented in API-v2: 09095e5

Marking this as a WONTFIX for API-v1