Skip to content
This repository has been archived by the owner on Mar 30, 2022. It is now read-only.

Upgrade to use Polyamorous ~> 1.2 #379

Open
thomasfedb opened this issue May 13, 2015 · 7 comments
Open

Upgrade to use Polyamorous ~> 1.2 #379

thomasfedb opened this issue May 13, 2015 · 7 comments

Comments

@thomasfedb
Copy link

Applications that use Ransack and Squeel currently have to use an old version of Ransack as the latest Ransack requires Polyamorous ~> 1.2, whereas Squeel depends on ~> 1.1.0.

@konung
Copy link

konung commented May 28, 2015

Bump. Same issue. Downgraded to ransack 1.6.5 for now.

Bundler could not find compatible versions for gem "polyamorous":
  In Gemfile:
    squeel (~> 1.2.3) ruby depends on
      polyamorous (~> 1.1.0) ruby

    ransack (~> 1.6.6) ruby depends on
      polyamorous (~> 1.2) ruby

@kiela
Copy link

kiela commented Jun 3, 2015

Bump again. I'm having issue with simple_form + Ransack which has been solved here. However, I'm not able to upgrade Ransack to the latest version because Squeel doesn't allow me to do this.

@onlinetocode
Copy link

Bump. Same issue. Downgraded to ransack 1.6.5 for now, too.

@thomasfedb
Copy link
Author

I decided to put some money behind this. Anybody else care to chip in?

BountySource

gmcnaughton pushed a commit to curious/squeel that referenced this issue Sep 12, 2015
Since polyamorous 1.1.0 [differs from 1.2.0](activerecord-hackery/polyamorous@ca95023) only by the version number and the README file, it's perfectly unacquired to simply change the dependency version.

Copied from [5bf84bd](activerecord-hackery/squeel@5bf84b) which is not on the master branch, so can't be referenced.
@bbozo
Copy link

bbozo commented Oct 26, 2015

Wow :D @denim2x fixed this 4 months ago? :) is it OK to close this and push changes to rubygems?

@jk779 jk779 mentioned this issue Jan 8, 2016
@oleander
Copy link

oleander commented Jan 8, 2016

@bbozo PR #401 has 3 failing tests on my machine and in travis-ci, so I guess there's some more work to do.

@grimmwerks
Copy link

I'm still getting this:

Bundler could not find compatible versions for gem "polyamorous":
  In Gemfile:
    polyamorous

    ransack was resolved to 1.8.1, which depends on
      polyamorous (~> 1.3)

    squeel was resolved to 1.2.3, which depends on
      polyamorous (~> 1.1.0)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants