Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tags [:bdi, :rp, :rt, :ruby, :u, :dialog] #654

Closed
barnaclebarnes opened this issue Jan 31, 2025 · 2 comments · Fixed by #655
Closed

Missing tags [:bdi, :rp, :rt, :ruby, :u, :dialog] #654

barnaclebarnes opened this issue Jan 31, 2025 · 2 comments · Fixed by #655
Assignees
@tagliala

Comments

@barnaclebarnes
Copy link

the tags :bdi, dilaog, :rp, :rt, :ruby, and :u are missing from HTML5_ELEMENTS

They should be added to AUTO_BUILD_ELEMENTS in lib/arbre/html/html5_elements.rb.
@tagliala tagliala self-assigned this Jan 31, 2025
tagliala added a commit that referenced this issue Jan 31, 2025
@tagliala
Add some missing HTML5 elements
d78ebaa 
Source: https://developer.mozilla.org/en-US/docs/Web/HTML

New, non experimental, non deprecated elements:
- <bdi>
- <data>
- <dialog>
- <picture>
- <rp>
- <rt>
- <ruby>
- <search>
- <slot>
- <template>
- <u>

Close #654
@tagliala tagliala mentioned this issue Jan 31, 2025
Merged
tagliala added a commit that referenced this issue Jan 31, 2025
@tagliala
Add some missing HTML5 elements
be063a9 
Source: https://developer.mozilla.org/en-US/docs/Web/HTML

New, non experimental, non deprecated elements:
- <bdi>
- <data>
- <dialog>
- <picture>
- <rp>
- <rt>
- <ruby>
- <search>
- <slot>
- <template>
- <u>

Close #654
@tagliala
Copy link
Contributor

Hi @barnaclebarnes, if you want to take a look at #655 feature/654-add-missing-html5-elements

@tagliala
Copy link
Contributor

tagliala commented Feb 2, 2025

Released as 2.2.0, thanks

https://github.com/activeadmin/arbre/releases/tag/v2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tagliala tagliala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing HTML5 elements activeadmin/arbre
2 participants
@barnaclebarnes @tagliala