-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency graph to README #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that a dependency graph would be of great value. I checked the dependencies and didn't notice any inconsistencies. Probably, if you move SoleFeatures.jl on the right side there won't be any arrows overlapping and it would make the graph even more clear.
I agree with @alberto-paparella, so I tried to play with mermaid to force SF node to stick on the right. It seems to me that forcing these behaviors in mermaid is very unintuitive, so I opted for a solution that takes advantage of subgraphs. Perhaps this is easier to maintain? Tell me what you think, for now README contains both @giopaglia and mine version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mauro-milella. I feel like the second version is more clear.
Wow @mauro-milella , the second one is beautiful!
The formatting could consist of making the text bold, italic, underlined, or may have to do with a particular border style for these nodes. Now, there is still something missing: Audio911.jl and SoleAudio.jl; but those two packages are not usable and we are not actively mantaining them, @PasoStudio73 should we add them here or not? Maybe we should add Audio911.jl as a dependency for SoleFeatures.jl? With the idea that SoleAudio in the future will be an extension of SoleFeatures. Do you people have thoughts? Thx |
The idea of adding signs (and a legend) is super nice! I leave the floor to paso for the considerations about SoleAudio. |
I have some suggestion: I would change the color of the central node (Sole.jl). I feel like it should be different from the three nodes above and, being outside a box, I propose it to be white as the other nodes outside boxes.
I agree with the formatting syntax to specify which of them are solid and which are not. Maybe underline or bold is more visible than italic.
I think that we should not wait for those packages to be ready to publish the current dependency graph. Instead I suggest to merge this and open a new Issue for |
SoleAudio.jl Audio911.jl |
Great! This will do for now. However, it only depends on SoleData because of a convenient method that calls
This is useful when one wants to apply a symbolic model to a DataFrame directly, for example, without having to call scalarlogiset explicitly. But for now adding an edge SoleModels -> SoleData would only clutter the nice symmetric visualization. Grazie ragazzi! |
We need a public dependency graph for the project. This is a first attempt.