Skip to content

Commit e6e0e7b

Browse files
Laszlo Ersekmergify[bot]
Laszlo Ersek
authored andcommitted
EmbeddedPkg/TemplateRealTimeClockLib: drop LibRtcVirtualNotifyEvent
The RealTimeClockLib class header in edk2 mistakenly declares a function called LibRtcVirtualNotifyEvent(). No component ever calls this function crossing module boundaries; all RealTimeClockLib instances in edk2 and edk2-platforms are supposed to register (and do register) their SetVirtualAddressMap() notification functions. In particular, TemplateRealTimeClockLib *itself* doesn't even use LibRtcVirtualNotifyEvent() -- the function is defined with an empty body, clearly in an understandable, but misguided, attempt, to conform to the (bogus) library interface. Remove the function. Build-tested only (with "EmbeddedPkg.dsc"). Cc: Abner Chang <[email protected]> Cc: Ard Biesheuvel <[email protected]> Cc: Daniel Schaefer <[email protected]> Cc: Leif Lindholm <[email protected]> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4564 Signed-off-by: Laszlo Ersek <[email protected]> Message-Id: <[email protected]> Reviewed-by: Ard Biesheuvel <[email protected]>
1 parent 189addf commit e6e0e7b

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

EmbeddedPkg/Library/TemplateRealTimeClockLib/RealTimeClockLib.c

-24
Original file line numberDiff line numberDiff line change
@@ -133,27 +133,3 @@ LibRtcInitialize (
133133
//
134134
return EFI_SUCCESS;
135135
}
136-
137-
/**
138-
Fixup internal data so that EFI can be call in virtual mode.
139-
Call the passed in Child Notify event and convert any pointers in
140-
lib to virtual mode.
141-
142-
@param[in] Event The Event that is being processed
143-
@param[in] Context Event Context
144-
**/
145-
VOID
146-
EFIAPI
147-
LibRtcVirtualNotifyEvent (
148-
IN EFI_EVENT Event,
149-
IN VOID *Context
150-
)
151-
{
152-
//
153-
// Only needed if you are going to support the OS calling RTC functions in virtual mode.
154-
// You will need to call EfiConvertPointer (). To convert any stored physical addresses
155-
// to virtual address. After the OS transitions to calling in virtual mode, all future
156-
// runtime calls will be made in virtual mode.
157-
//
158-
return;
159-
}

0 commit comments

Comments
 (0)