Skip to content

Commit 086ba5d

Browse files
buxbux
authored
Documentation - Fix various lighthouse issues (#8600)
* fix various lighthouse issues * remove bom FROM AN AUTOGENERATED FILE
1 parent a801d0d commit 086ba5d

13 files changed

+4634
-56
lines changed

‎docs/_includes/_footer.html

+9-3
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,15 @@ <h2>Issues / Feedback</h2>
1414
<div class="large-4 columns">
1515
<h2>Social Media</h2>
1616
<div class="social__icons">
17-
<a class="social__icon" href="https://twitter.com/ACE3Mod" target="_blank" onclick="app.analytics.sendEvent('ExternalLink', 'Click', this.href);" rel="noopener"><i class="fa fa-twitter fa-2x"></i></a>
18-
<a class="social__icon" href="https://facebook.com/ACE3Mod" target="_blank" onclick="app.analytics.sendEvent('ExternalLink', 'Click', this.href);" rel="noopener"><i class="fa fa-facebook-square fa-2x"></i></a>
19-
<a class="social__icon" href="https://youtube.com/c/ACE3Mod" target="_blank" onclick="app.analytics.sendEvent('ExternalLink', 'Click', this.href);" rel="noopener"><i class="fa fa-youtube fa-2x"></i></a>
17+
<a class="social__icon" href="https://twitter.com/ACE3Mod" target="_blank" onclick="app.analytics.sendEvent('ExternalLink', 'Click', this.href);" rel="noopener" aria-label="ACE3 on Twitter">
18+
<i class="fa fa-twitter fa-2x"></i>
19+
</a>
20+
<a class="social__icon" href="https://facebook.com/ACE3Mod" target="_blank" onclick="app.analytics.sendEvent('ExternalLink', 'Click', this.href);" rel="noopener" aria-label="ACE3 on Facebook">
21+
<i class="fa fa-facebook-square fa-2x"></i>
22+
</a>
23+
<a class="social__icon" href="https://youtube.com/c/ACE3Mod" target="_blank" onclick="app.analytics.sendEvent('ExternalLink', 'Click', this.href);" rel="noopener" aria-label="ACE3 on YouTube">
24+
<i class="fa fa-youtube fa-2x"></i>
25+
</a>
2026
</div>
2127
<script async defer src="https://slackin.ace3mod.com/slackin.js"></script>
2228
</div>

‎docs/_includes/_header.html

+3-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
<meta name="description" content="{% if page.description != null %}{{ page.description }}{% else %}{{site.description}}{% endif %}" />
99
<meta name="keywords" content="{% if page.keywords != null %}{{ page.keywords }}{% else %}{{site.keywords}}{% endif %}" />
1010
<meta name="robots" content="INDEX,FOLLOW" />
11-
<link rel="canonical" href="{{ site.baseurl }}{{ page.url }}" />
1211
<meta http-equiv="X-UA-Compatible" content="IE=Edge" />
1312
<link type="text/plain" rel="author" href="{{ site.baseurl }}/humans.txt" />
1413

@@ -25,7 +24,9 @@
2524
<link rel="manifest" href="/manifest.json">
2625
<meta name="theme-color" content="#951E14">
2726

28-
<link href="//fonts.googleapis.com/css?family=Open+Sans:400italic,700italic,400,700" rel="stylesheet" type="text/css" />
27+
<link rel="preconnect" href="https://fonts.googleapis.com">
28+
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
29+
<link href="https://fonts.googleapis.com/css2?family=Open+Sans:ital,wght@0,400;0,700;1,400;1,700&display=swap" rel="stylesheet">
2930
<link rel="stylesheet" href="{{ site.baseurl }}/css/app.css?v={{site.time | date: '%Y%m%d%H'}}" />
3031
</head>
3132
<body>

‎docs/css/app.css

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/js/footer.dev.js

+4-4
Large diffs are not rendered by default.

‎docs/js/footer.min.js

+1-6
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/js/footer.min.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/src/Gruntfile.js

+8-26
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
module.exports = function (grunt) {
22

3-
/*var header = [
4-
5-
];*/
3+
const sass = require("node-sass");
64

75
var footer = [
86
"js/vendor/modernizr/modernizr.custom.18747.js",
@@ -25,6 +23,7 @@ module.exports = function (grunt) {
2523

2624
sass: {
2725
options: {
26+
implementation: sass,
2827
includePaths: ["components/foundation/scss"]
2928
},
3029
dist: {
@@ -58,29 +57,12 @@ module.exports = function (grunt) {
5857
}
5958
},
6059
concat: {
61-
//header: {
62-
// src: [header],
63-
// dest: "../js/header.dev.js"
64-
//},
6560
footer: {
6661
src: [footer],
6762
dest: "../js/footer.dev.js"
6863
}
6964
},
7065
uglify: {
71-
//"header": {
72-
// options: {
73-
// sourceMap: "../js/header-source-map.js",
74-
// sourceMappingURL: "header-source-map.js",
75-
// sourceMapPrefix: 2,
76-
// sourceMapRoot: "../../dist/js/",
77-
// mangle: true,
78-
// compress: true
79-
// },
80-
// files: {
81-
// "../js/header.min.js": [header]
82-
// }
83-
//},
8466
"footer": {
8567
options: {
8668
sourceMap: "../js/footer-source-map.js",
@@ -96,12 +78,12 @@ module.exports = function (grunt) {
9678
}
9779
},
9880
imagemin: {
99-
dynamic: { // Another target
81+
dynamic: { // Another target
10082
files: [{
101-
expand: true, // Enable dynamic expansion
102-
cwd: "img/", // Src matches are relative to this path
103-
src: ["**/*.{png,jpg,gif}"], // Actual patterns to match
104-
dest: "../img/" // Destination path prefix
83+
expand: true, // Enable dynamic expansion
84+
cwd: "img/", // Src matches are relative to this path
85+
src: ["**/*.{png,jpg,gif}"], // Actual patterns to match
86+
dest: "../img/" // Destination path prefix
10587
}]
10688
}
10789
}
@@ -113,6 +95,6 @@ module.exports = function (grunt) {
11395
grunt.loadNpmTasks("grunt-contrib-uglify");
11496
grunt.loadNpmTasks("grunt-contrib-imagemin");
11597

116-
grunt.registerTask("build", ["sass", "concat", /*"uglify:header",*/ "uglify:footer", "imagemin"]);
98+
grunt.registerTask("build", ["sass", "concat", "uglify:footer"]);
11799
grunt.registerTask("default", ["build", "watch"]);
118100
};

‎docs/src/js/vendor/jquery/jquery.min.js

+4-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/src/package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
"grunt-contrib-imagemin": "^3.1.0",
1111
"grunt-contrib-uglify": "^4.0.0",
1212
"grunt-contrib-watch": "^1.1.0",
13-
"grunt-sass": "^3.0.2"
13+
"grunt-sass": "^3.0.2",
14+
"node-sass": "^6.0.1"
1415
}
1516
}

0 commit comments

Comments
 (0)