Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of the Via Points #769

Open
afischerdev opened this issue Mar 25, 2025 · 2 comments
Open

Handling of the Via Points #769

afischerdev opened this issue Mar 25, 2025 · 2 comments

Comments

@afischerdev
Copy link
Collaborator

A while ago we introduced the correction of the via points #494 (misplaced via points). This produce something like this situation:

Image

BRouter clients can use the segment by segment calculation (blue path) or an all in one calculation with the chance to remove unexpected way parts (red path). The all in one method has its problem in the recalculation, all is done again. While segment routing only ask for the parts before and after the moved via point.

What if the BRouter library returns the replaced via points. All clients have the chance now to do the recalculation from the corrected point and merge the parts there.

Image

What do you think?

Please keep in mind, the misplace logic is not complete now. #519 is not done now for the roundabouts.

@devemux86
Copy link
Contributor

@afischerdev

What if the BRouter library returns the replaced via points.

What BRouter returns now? Doesn't it return the corrected via points in the turn instructions?

This method will again work when we do all in one calculation and not in segment by segment calculation?

@afischerdev
Copy link
Collaborator Author

@devemux86

What BRouter returns now?

Nothing but the route. We have the option exportWaypoints=1 that brings the waypoints into the export and there could be an option exportCorrectedWaypoints=1 for example.

Doesn't it return the corrected via points in the turn instructions?

No, At this via point it would be a turn instruction straight and that is removed.
Only the timode=2 (Locus) has a marker:

<trkpt lon="13.196587" lat="52.467697"><ele>40.75</ele><sym>pass_place</sym><type>Via</type></trkpt>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants