fix: update to use SPUStandardUpdaterController from sparkle v2 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanwen
changed the title
|
Amazing, thanks! I was a little too busy to review this but will do so in the next couple of days. |
|
@abemedia no worries, it can wait, thank you |
This was referenced Dec 26, 2023
|
@abemedia Would you be able to find some time to take a look at the PR? We've been using the change in prod for a while and haven't noticed issues so far, so I can say it's safe enough, however, I would be happy to get any feedback on the code structure. I might be able to bring other APIs from the sparkle, but wouldn't want to go deep without the baseline aligned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR is doing
Fixes #11 by adopting the recommended
SPUStandardUpdaterControllerwhich creates the default UI and necessary delegates.Feed URL and decryption password settings migrated to
SPUUpdaterDelegateas methodsfeedURLStringForUpdateranddecryptionPasswordForUpdater, so to eliminate warnings, I had to implement those.feedURLStringForUpdatercalls go function to provide results, which could add some extensibility, however, I haven't changed the library API just yet to expose this way of setting the feed URL.This PR should be backwards-compatible, but I was forced to export
CGOFeedURLto use it in the ObjC code. Any suggestions on the naming will be appreciated to indicate, that this is an internal function and implementation detail.I also slightly tampered with the example to make sure the affected methods did not cause any crashes and still worked fine.
I also had to add a clearFeedURLFromUserDefaults call, during my tests with the previous
setFeedURLversion it persisted the URL and didn't get back to the one fromInfo.plist. With this call that was fixed. So I suspect it's a necessary migration stepWhy this PR is important
Having those deprecation warnings is annoying, so I thought It would be nice to finally migrate to a modern second version of the Sparkle API and get familiar with the binding in case I would need more methods exposed in the future